gh-111789: Use PyDict_GetItemRef() in Python/codecs.c (gh-112082)

python · Nov 27, 2023 · aa438bd · aa438bd
1 parent 395fd9c
commit aa438bd
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/Python/codecs.c b/Python/codecs.c
@@ -146,15 +146,14 @@ PyObject *_PyCodec_Lookup(const char *encoding)
  PyUnicode_InternInPlace(&v);
 
  /* First, try to lookup the name in the registry dictionary */
- PyObject *result = PyDict_GetItemWithError(interp->codec_search_cache, v);
+ PyObject *result;
+ if (PyDict_GetItemRef(interp->codec_search_cache, v, &result) < 0) {
+ goto onError;
+ }
  if (result != NULL) {
- Py_INCREF(result);
  Py_DECREF(v);
  return result;
  }
- else if (PyErr_Occurred()) {
- goto onError;
- }
 
  /* Next, scan the search functions in order of registration */
  const Py_ssize_t len = PyList_Size(interp->codec_search_path);