bpo-30961: Fix decrementing a borrowed reference in tracemalloc. (#2747…

…) (#2749) (cherry picked from commit 4ed5ad7)
python · Jul 18, 2017 · cb3f024 · cb3f024
1 parent 45c471c
commit cb3f024
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Misc/NEWS.d/next/Library/2017-07-18-23-47-51.bpo-30961.064jz0.rst b/Misc/NEWS.d/next/Library/2017-07-18-23-47-51.bpo-30961.064jz0.rst
@@ -0,0 +1 @@
+Fix decrementing a borrowed reference in tracemalloc.
diff --git a/Modules/_tracemalloc.c b/Modules/_tracemalloc.c
@@ -1408,7 +1408,7 @@ _PyTraceMalloc_Init(void)
         if (key == NULL)
             return -1;
 
-        value = PyDict_GetItemWithError(xoptions, key);
+        value = PyDict_GetItemWithError(xoptions, key); /* borrowed */
         Py_DECREF(key);
         if (value == NULL) {
             if (PyErr_Occurred())
@@ -1419,7 +1419,6 @@ _PyTraceMalloc_Init(void)
         }
 
         nframe = parse_sys_xoptions(value);
-        Py_DECREF(value);
         if (nframe < 0) {
             Py_FatalError("-X tracemalloc=NFRAME: invalid number of frames");
         }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix decrementing a borrowed reference in tracemalloc.