gh-87604: Avoid publishing list of active per-interpreter audit hooks…

… via the gc module (GH-99373)

(cherry picked from commit 4e4b13e)

Co-authored-by: Steve Dower <steve.dower@python.org>

Lib/test/audit-tests.py

@@ -429,6 +429,17 @@ def hook(event, args):
  syslog.closelog()
 
 
+def test_not_in_gc():
+ import gc
+
+ hook = lambda *a: None
+ sys.addaudithook(hook)
+
+ for o in gc.get_objects():
+ if isinstance(o, list):
+ assert hook not in o
+
+
 if __name__ == "__main__":
  from test.support import suppress_msvcrt_asserts
 

Lib/test/test_audit.py

@@ -195,6 +195,11 @@ def test_syslog(self):
  ('syslog.closelog', '', '')]
  )
 
+ def test_not_in_gc(self):
+ returncode, _, stderr = self.run_python("test_not_in_gc")
+ if returncode:
+ self.fail(stderr)
+
 
 if __name__ == "__main__":
  unittest.main()

Misc/NEWS.d/next/Security/2022-11-11-12-50-28.gh-issue-87604.OtwH5L.rst

@@ -0,0 +1,2 @@
+Avoid publishing list of active per-interpreter audit hooks via the
+:mod:`gc` module

Python/sysmodule.c

@@ -462,6 +462,8 @@ sys_addaudithook_impl(PyObject *module, PyObject *hook)
  if (interp->audit_hooks == NULL) {
  return NULL;
  }
+ /* Avoid having our list of hooks show up in the GC module */
+ PyObject_GC_UnTrack(interp->audit_hooks);
  }
 
  if (PyList_Append(interp->audit_hooks, hook) < 0) {