Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests for asyncio subprocess #100192

Closed
kumaraditya303 opened this issue Dec 12, 2022 · 0 comments · Fixed by #100194
Closed

Add more tests for asyncio subprocess #100192

kumaraditya303 opened this issue Dec 12, 2022 · 0 comments · Fixed by #100194
Assignees
@kumaraditya303
Labels
3.12 bugs and security fixes tests Tests in the Lib/test dir topic-asyncio

Comments

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Dec 12, 2022 •
edited by bedevere-bot
Loading

As evident from #100133, we need more functional tests for subprocess. Currently there are only two tests for shell and others don't tests all combinations.

Linked PRs
@kumaraditya303 kumaraditya303 added topic-asyncio 3.11 only security fixes 3.12 bugs and security fixes labels Dec 12, 2022
@kumaraditya303 kumaraditya303 self-assigned this Dec 12, 2022
@ezio-melotti ezio-melotti moved this to Todo in asyncio Dec 12, 2022
@AlexWaygood AlexWaygood added the tests Tests in the Lib/test dir label Dec 12, 2022
@bedevere-bot bedevere-bot mentioned this issue Dec 12, 2022
Merged
@kumaraditya303 kumaraditya303 linked a pull request Dec 28, 2022 that will close this issue
GH-100192: add more asyncio subprocess tests #100194
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in asyncio Dec 28, 2022
kumaraditya303 added a commit that referenced this issue Dec 28, 2022
@kumaraditya303
GH-100192: add more asyncio subprocess tests (#100194)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e97afef
@bedevere-bot bedevere-bot mentioned this issue Dec 28, 2022
Merged
kumaraditya303 added a commit that referenced this issue Dec 28, 2022
@kumaraditya303
GH-100192: fix asyncio subprocess tests to pass env vars to subproc…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
6835184 
…ess (#100569)
@kumaraditya303 kumaraditya303 removed the 3.11 only security fixes label Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumaraditya303 kumaraditya303

Labels
3.12 bugs and security fixes tests Tests in the Lib/test dir topic-asyncio
Projects
asyncio
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-100192: add more asyncio subprocess tests kumaraditya303/cpython
2 participants
@kumaraditya303 @AlexWaygood