Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_peg_generator to not need distutils & reenable it #100238

Closed
encukou opened this issue Dec 14, 2022 · 8 comments
Closed

Update test_peg_generator to not need distutils & reenable it #100238

encukou opened this issue Dec 14, 2022 · 8 comments
Labels
tests Tests in the Lib/test dir

Comments

@encukou
Copy link
Member

encukou commented Dec 14, 2022 •
edited by bedevere-bot
Loading

distutils was removed from 3.12, as per PEP 632.
test_peg_generator, which uses it, was disabled. It should be updated to not need distutils.

See #92584

Linked PRs
@encukou encukou added the tests Tests in the Lib/test dir label Dec 14, 2022
@ramvikrams
Copy link
Contributor

I'd like to work on this I looked through test_peg_generator but I could not find any test that importing distuils

@AlexWaygood AlexWaygood mentioned this issue Mar 8, 2023
Merged
@ericsnowcurrently
Copy link
Member

@Yhg1s, this feels like a release blocker. Thoughts?

@ericsnowcurrently
Copy link
Member

ericsnowcurrently commented Mar 8, 2023 •
edited
Loading

@ramvikrams, distutils is used in Tools/peg_generator/pegen/build.py, which I'm guessing is exercised by tests under Lib/test/test_peg_generator. See the comment in Lib/test/test_peg_generator/__init__.py.

@ramvikrams
Copy link
Contributor

@ramvikrams, distutils is used in Tools/peg_generator/pegen/build.py, which I'm guessing is exercised by tests under Lib/test/test_peg_generator. See the comment in Lib/test/test_peg_generator/init.py.

Thanks I'll check it

@ericsnowcurrently
Copy link
Member

FYI, we may want to solve this in a way that can be shared between the c-analyzer and peg_generator tools. See #92584 (comment).

@Yhg1s
Copy link
Member

Yhg1s commented Mar 8, 2023

Yes, I consider this a release blocker for the betas (#92584 is left open as a release blocker for this reason).

@ramvikrams
Copy link
Contributor

ramvikrams commented Mar 12, 2023 •
edited
Loading

I looked through the file but I had a question should I replace distutils with setuptools in Tools/peg_generator/pegen/build.py

@bedevere-bot bedevere-bot mentioned this issue May 22, 2023
Closed
lysnikolaou added a commit to lysnikolaou/cpython that referenced this issue May 23, 2023
@lysnikolaou
pythongh-100238: Use setuptools in peg-generator and reenable tests
88edfa7
@bedevere-bot bedevere-bot mentioned this issue May 23, 2023
Merged
lysnikolaou added a commit that referenced this issue May 26, 2023
@lysnikolaou
gh-100238: Use setuptools in peg-generator and reenable tests (#104798)
afa759f
@lysnikolaou
Copy link
Member

Resolved in #104798.

@lysnikolaou lysnikolaou mentioned this issue May 26, 2023
Closed
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 31, 2023
@lysnikolaou @miss-islington
pythongh-100238: Use setuptools in peg-generator and reenable tests (p…
4e73547 
…ythonGH-104798)

(cherry picked from commit afa759f)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue May 31, 2023
Merged
lysnikolaou added a commit that referenced this issue Jul 5, 2023
@miss-islington @lysnikolaou
[3.12] gh-100238: Use setuptools in peg-generator and reenable tests (G…
6371029 
…H-104798) (#105135)

(cherry picked from commit afa759f)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@encukou @ericsnowcurrently @Yhg1s @lysnikolaou @ramvikrams