Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dict comprehensions are not tested at all in test_named_expressions.py #100746

Closed
sobolevn opened this issue Jan 4, 2023 · 1 comment
Closed

Dict comprehensions are not tested at all in test_named_expressions.py #100746

sobolevn opened this issue Jan 4, 2023 · 1 comment
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Jan 4, 2023 •
edited by bedevere-app bot
Loading

While working on #100581 I've noticed that we do not test dict comprehensions at all there.

I think that this needs to be improved.
I will add test case for them soon, PR is in the works.

Linked PRs
@sobolevn sobolevn added the type-bug An unexpected behavior, bug, or error label Jan 4, 2023
@sobolevn sobolevn self-assigned this Jan 4, 2023
@sobolevn sobolevn mentioned this issue Jan 4, 2023
Merged
@iritkatriel iritkatriel added the tests Tests in the Lib/test dir label Nov 26, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Mar 13, 2024
@sobolevn
pythongh-100746: Improve test_named_expressions.py
3f1f757
sobolevn added a commit to sobolevn/cpython that referenced this issue Mar 13, 2024
@sobolevn
pythongh-100746: Improve test_named_expressions.py
b1562be
@bedevere-app bedevere-app bot mentioned this issue Mar 13, 2024
Merged
sobolevn added a commit that referenced this issue Mar 13, 2024
@sobolevn
gh-100746: Improve test_named_expressions.py (#116713)
25684e7
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 13, 2024
@sobolevn @miss-islington
pythongh-100746: Improve test_named_expressions.py (pythonGH-116713)
0b2e876 
(cherry picked from commit 25684e7)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 13, 2024
@sobolevn @miss-islington
pythongh-100746: Improve test_named_expressions.py (pythonGH-116713)
4e72e66 
(cherry picked from commit 25684e7)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
This was referenced Mar 13, 2024
Merged
Closed
sobolevn added a commit that referenced this issue Mar 13, 2024
@miss-islington @sobolevn
[3.12] gh-100746: Improve test_named_expressions.py (GH-116713) (#1…
734c5c4 
…16747)

gh-100746: Improve `test_named_expressions.py` (GH-116713)
(cherry picked from commit 25684e7)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
vstinner pushed a commit to vstinner/cpython that referenced this issue Mar 20, 2024
@sobolevn @vstinner
pythongh-100746: Improve test_named_expressions.py (python#116713)
41f5bc2
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
@sobolevn @adorilson
pythongh-100746: Improve test_named_expressions.py (python#116713)
69861cd
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@sobolevn @diegorusso
pythongh-100746: Improve test_named_expressions.py (python#116713)
1e73fce
@hugovk
Copy link
Member

hugovk commented Jun 15, 2024

Triage: the linked PRs are merged/closed, can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iritkatriel @hugovk @sobolevn