Skip to content

email: address list folding encodes list-separator comma #100884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
t-8ch opened this issue Jan 9, 2023 · 1 comment · Fixed by #100885
Closed

email: address list folding encodes list-separator comma #100884

t-8ch opened this issue Jan 9, 2023 · 1 comment · Fixed by #100885
Labels
topic-email type-bug An unexpected behavior, bug, or error

Comments

@t-8ch
Copy link
Contributor

t-8ch commented Jan 9, 2023 •
edited by bedevere-app bot
Loading

Bug report

When during address list folding a separating comma ends up on a folded line containing that is to be unicode-encoded than the separator itself is also unicode encoded. Instead the comma should still a plain comma.

This is rejected by some mail servers:

ZZZ: host YYY said:
    550 Invalid address in message header. Consult RFC2822. (in reply to end of
    DATA command)

Minimal example:

>>> import email
>>> m = email.message.EmailMessage()
>>> t = '01234567890123456789012345678901234567890123456789012345678901@example.org, ä <foo@example.org>'
>>> m['to'] = t
>>> m.as_string()
'to: 01234567890123456789012345678901234567890123456789012345678901@example.org\n =?utf-8?q?=2C?= =?utf-8?q?=C3=A4?= <foo@example.org>\n\n'

Your environment

  • CPython versions tested on: 3.10.9, latest main (e47b139)
  • Operating system and architecture: ArchLinux x86_64

Linked PRs
@t-8ch t-8ch added the type-bug An unexpected behavior, bug, or error label Jan 9, 2023
t-8ch added a commit to t-8ch/cpython that referenced this issue Jan 9, 2023
@t-8ch
pythonGH-100884: email/_header_value_parser: use existing ListSeparator
b1f41b8 
There already is already a predefined object with the correct
properties, use it.
t-8ch added a commit to t-8ch/cpython that referenced this issue Jan 9, 2023
@t-8ch
pythonGH-100884: email/_header_value_parser: don't encode list separa…
98ab61d 
…tors

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.

Fixes python#100884
@t-8ch t-8ch mentioned this issue Jan 9, 2023
Merged
t-8ch added a commit to t-8ch/cpython that referenced this issue Jan 9, 2023
@t-8ch
pythonGH-100884: email/_header_value_parser: don't encode list separa…
75a89ca 
…tors

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.

Fixes python#100884
mricon added a commit to mricon/b4 that referenced this issue Jan 9, 2023
@mricon
tests: add another test for very long email address
26e7d3c 
This tests for the bug reported here:
python/cpython#100884

Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
serhiy-storchaka pushed a commit that referenced this issue Feb 17, 2024
@t-8ch
gh-100884: email/_header_value_parser: don't encode list separators (G…
09fab93 
…H-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 17, 2024
@t-8ch @miss-islington
pythongh-100884: email/_header_value_parser: don't encode list separa…
5f617f2 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
(cherry picked from commit 09fab93)

Co-authored-by: Thomas Weißschuh <thomas@t-8ch.de>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 17, 2024
@t-8ch @miss-islington
pythongh-100884: email/_header_value_parser: don't encode list separa…
a2640a5 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
(cherry picked from commit 09fab93)

Co-authored-by: Thomas Weißschuh <thomas@t-8ch.de>
This was referenced Feb 17, 2024
Merged
Merged
serhiy-storchaka pushed a commit that referenced this issue Feb 17, 2024
@miss-islington @t-8ch
[3.12] gh-100884: email/_header_value_parser: don't encode list separ…
9148b77 
…ators (GH-100885) (GH-115592)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
(cherry picked from commit 09fab93)

Co-authored-by: Thomas Weißschuh <thomas@t-8ch.de>
serhiy-storchaka pushed a commit that referenced this issue Feb 17, 2024
@miss-islington @t-8ch
[3.11] gh-100884: email/_header_value_parser: don't encode list separ…
70754d2 
…ators (GH-100885) (GH-115593)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
(cherry picked from commit 09fab93)

Co-authored-by: Thomas Weißschuh <thomas@t-8ch.de>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this issue Mar 4, 2024
@t-8ch @woodruffw
pythongh-100884: email/_header_value_parser: don't encode list separa…
90daba0 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@t-8ch @diegorusso
pythongh-100884: email/_header_value_parser: don't encode list separa…
8b88128 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
@serhiy-storchaka serhiy-storchaka mentioned this issue May 10, 2024
Closed
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue May 16, 2024
@serhiy-storchaka
pythongh-118643: Fix AttributeError in the email module
ad85b83 
Fix regression introduced in pythongh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in pythongh-100884.
@serhiy-storchaka serhiy-storchaka mentioned this issue May 16, 2024
Merged
serhiy-storchaka added a commit that referenced this issue May 22, 2024
@serhiy-storchaka
gh-118643: Fix AttributeError in the email module (GH-119099)
858b9e8 
Fix regression introduced in gh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in gh-100884.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 22, 2024
@serhiy-storchaka @miss-islington
pythongh-118643: Fix AttributeError in the email module (pythonGH-119099
6d4b54f 
)

Fix regression introduced in pythongh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in pythongh-100884.
(cherry picked from commit 858b9e8)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington miss-islington mentioned this issue May 22, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 22, 2024
@serhiy-storchaka @miss-islington
pythongh-118643: Fix AttributeError in the email module (pythonGH-119099
d111cba 
)

Fix regression introduced in pythongh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in pythongh-100884.
(cherry picked from commit 858b9e8)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington miss-islington mentioned this issue May 22, 2024
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue May 22, 2024
@serhiy-storchaka
[3.11] pythongh-118643: Fix AttributeError in the email module (pytho…
9bfb6ae 
…nGH-119099)

Fix regression introduced in pythongh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in pythongh-100884.
(cherry picked from commit 858b9e8)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka mentioned this issue May 22, 2024
Merged
serhiy-storchaka added a commit that referenced this issue May 22, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-118643: Fix AttributeError in the email module (GH-119099) (G…
6892b40 
…H-119389)

Fix regression introduced in gh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in gh-100884.
(cherry picked from commit 858b9e8)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this issue May 22, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-118643: Fix AttributeError in the email module (GH-119099) (G…
8c96850 
…H-119390)

Fix regression introduced in gh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in gh-100884.
(cherry picked from commit 858b9e8)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
pablogsal pushed a commit that referenced this issue May 23, 2024
@serhiy-storchaka
[3.11] gh-118643: Fix AttributeError in the email module (GH-119099) (#…
4762b36 
…119393)

Fix regression introduced in gh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in gh-100884.
(cherry picked from commit 858b9e8)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@serhiy-storchaka @estyxx
pythongh-118643: Fix AttributeError in the email module (pythonGH-119099
c068bee 
)

Fix regression introduced in pythongh-100884: AttributeError when re-fold a long
address list.

Also fix more cases of incorrect encoding of the address separator in the
address list missed in pythongh-100884.
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this issue Jan 22, 2025
@t-8ch @LukasWoodtli
pythongh-100884: email/_header_value_parser: don't encode list separa…
f306be6 
…tors (pythonGH-100885)

ListSeparator should not be encoded. This could happen when a long line
pushes its separator to the next line, which would have been encoded.
@medmunds medmunds mentioned this issue Feb 27, 2025
Merged
This was referenced Mar 5, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Draft
Merged
Merged
@mcepl
Copy link
Contributor

mcepl commented Mar 11, 2025

Shouldn’t CVE-2025-1795 be mentioned here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-email type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-100884: email/_header_value_parser: don't encode list separators t-8ch/cpython
3 participants
@mdboom @mcepl @t-8ch