Skip to content

System transitions tests are skipped in datetime tester #101539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abalkin opened this issue Feb 3, 2023 · 1 comment · Fixed by #101540
Closed

System transitions tests are skipped in datetime tester #101539

abalkin opened this issue Feb 3, 2023 · 1 comment · Fixed by #101540
Assignees
@abalkin
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@abalkin
Copy link
Member

abalkin commented Feb 3, 2023 •
edited
Loading

Bug report

Tests that should be conditionally skipped only when time.tzset is not present are skipped all the time.

% ./python.exe Lib/test/test_datetime.py -k test_system_transitions  -v
test_system_transitions (test.datetimetester.IranTest_Pure.test_system_transitions) ... skipped 'time module has no attribute tzset'
test_system_transitions (test.datetimetester.ZoneInfoTest_Pure.test_system_transitions) ... skipped 'time module has no attribute tzset'
test_system_transitions (test.datetimetester.ZoneInfoTest[Africa/Abidjan]_Pure.test_system_transitions) ... skipped 'time module has no attribute tzset'
test_system_transitions (test.datetimetester.ZoneInfoTest[Africa/Accra]_Pure.test_system_transitions) ... skipped 'time module has no attribute tzset'
test_system_transitions (test.datetimetester.ZoneInfoTest[Africa/Addis_Ababa]_Pure.test_system_transitions) ... skipped 'time module has no attribute tzset'
test_system_transitions (test.datetimetester.ZoneInfoTest[Africa/Algiers]_Pure.test_system_transitions) ... skipped 'time module has no attribute tzset'
...

----------------------------------------------------------------------
Ran 842 tests in 0.036s

OK (skipped=842)

Your environment

  • CPython versions tested on: 
    % ./python.exe
Python 3.12.0a4+ (heads/main:04e06e20ee, Feb  3 2023, 17:55:49) [Clang 14.0.0 (clang-1400.0.29.202)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
  • Operating system and architecture: macOS

Linked PRs
@abalkin abalkin added the type-bug An unexpected behavior, bug, or error label Feb 3, 2023
@abalkin abalkin self-assigned this Feb 3, 2023
@abalkin abalkin added the tests Tests in the Lib/test dir label Feb 3, 2023
@abalkin
Copy link
Member Author

abalkin commented Feb 3, 2023

It looks like the problem was introduced in #31898. I'll submit a fix shortly.

abalkin added a commit to abalkin/cpython-1 that referenced this issue Feb 3, 2023
@abalkin
Fix detection of presence of time.tzset (pythongh-101539)
5f6c356 
Resolves pythongh-101539
Related to pythongh-31898
@abalkin abalkin mentioned this issue Feb 3, 2023
Merged
abalkin added a commit that referenced this issue Feb 5, 2023
@abalkin
Fix detection of presence of time.tzset (gh-101539) (#101540)
ddd619c 
Resolves gh-101539
Related to gh-31898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abalkin abalkin

Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
Date and time issues 🕰️
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix detection of presence of time.tzset (gh-101539) abalkin/cpython-1
1 participant
@abalkin