-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
Closed
Labels
testsTests in the Lib/test dirTests in the Lib/test dirtopic-typingtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
Description
Right now we have several things to improve:
- This branch is not covered by tests:
Line 3490 in 4c87537
pass @override
will not fail for some weird cases. Since 99.99% of use-cases will simply be@override def some(...): ...
, it is not very important - but still desirable - We don't test
@classmethod
s, I guess it is special enough to be included @property
is also missing from tests, but is mentioned in PEP: https://peps.python.org/pep-0698/#specification and https://peps.python.org/pep-0698/#limitations-of-setting-override- PEP also mentions
@functools.lru_cache
and similar decorators as an example of how wrappers should be nested. Why don't we test it? Right now there are no tests for nested method decorators (exceptstaticmethod
) - It might not hurt to test that parent's methods definitions are not mutated (I think this is a part of the contract)
PR is on its way :)
Linked PRs
AlexWaygood and stroxler
Metadata
Metadata
Assignees
Labels
testsTests in the Lib/test dirTests in the Lib/test dirtopic-typingtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error