It is possible for python_tzpath_context to fail in test_zoneinfo

[pganssle]

Bug report

This code started failing the pylint check on backports.zoneinfo recently:

@staticmethod
@contextlib.contextmanager
def python_tzpath_context(value):
    path_var = "PYTHONTZPATH"
    try:
        with OS_ENV_LOCK:
           old_env = os.environ.get(path_var, None)
           os.environ[path_var] = value
           yield
    finally:
        if old_env is None:
            del os.environ[path_var]
        else:
            os.environ[path_var] = old_env  # pragma: nocover

It's kind of a non-issue, but it is true that if an error is raised while acquiring OS_ENV_LOCK or when calling os.environ.get, old_env won't be set, which will raise a NameError. This is a kind of rare situation anyway, and it would probably only come up during a non-recoverable error, but we may as well fix it — if only so that people who use CPython as an example of "good code" will have an example of the right way to handle this sort of situation.

Probably this is trivial enough that we can skip an issue and news, but I'll just create one anyway 😛

Linked PRs

• GH-102537: Handle check for PYTHONTZPATH failing in zoneinfo test #102538
• [3.11] GH-102537: Handle check for PYTHONTZPATH failing in zoneinfo test (GH-102538) #102586
• [3.10] GH-102537: Handle check for PYTHONTZPATH failing in zoneinfo test (GH-102538) #102587

[arhadthedev]

Should this issue be closed as resolved?

[hugovk]

Yes, let's close it :)