Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PEP 692 #103629

Closed
JelleZijlstra opened this issue Apr 19, 2023 · 4 comments
Closed

Implement PEP 692 #103629

JelleZijlstra opened this issue Apr 19, 2023 · 4 comments
Labels
3.12 bugs and security fixes topic-typing type-feature A feature request or enhancement

Comments

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Apr 19, 2023 •
edited by bedevere-bot
Loading

PEP-692 was accepted, but without the syntax change. That means there's very little to do in CPython, but a few changes should be made:

And maybe something else I'm forgetting.

cc @franekmagiera

Linked PRs
@JelleZijlstra JelleZijlstra added type-feature A feature request or enhancement topic-typing labels Apr 19, 2023
@franekmagiera
Copy link
Contributor

Thanks Jelle! I will try to find time to pick some of this up after the weekend.

@bedevere-bot bedevere-bot mentioned this issue Apr 26, 2023
Merged
@franekmagiera
Copy link
Contributor

franekmagiera commented Apr 26, 2023 •
edited
Loading

When it comes to typing.py - the repr for Unpack needs to be updated - I will try to do that later this week.

franekmagiera added a commit to franekmagiera/cpython that referenced this issue Apr 26, 2023
@franekmagiera
pythonGH-103629: Update NEWS and whatsnew with PEP-692 information
2cfa405
AlexWaygood pushed a commit that referenced this issue Apr 26, 2023
@franekmagiera
gh-103629: Update typing.Unpack docs in compliance with PEP 692 (#103894
dc3f975 
)
franekmagiera added a commit to franekmagiera/cpython that referenced this issue May 1, 2023
@franekmagiera
pythonGH-103629: Update Unpack's repr in compliance with PEP 692
2f26dbd
@bedevere-bot bedevere-bot mentioned this issue May 1, 2023
Merged
@AlexWaygood AlexWaygood added the 3.12 bugs and security fixes label May 1, 2023
franekmagiera added a commit to franekmagiera/cpython that referenced this issue May 1, 2023
@franekmagiera
pythonGH-103629: Prettify Unpack's repr
058a38e
@franekmagiera
Copy link
Contributor

typing rtd already mentions PEP 692, also added a PR to update mypy's cheatsheet

AlexWaygood pushed a commit that referenced this issue May 1, 2023
@franekmagiera
GH-103629: Update Unpack's repr in compliance with PEP 692 (#104048)
2d526cd
@AlexWaygood
Copy link
Member

I think we're done here! Easiest typing PEP to implement that I've been involved with 😄

carljm added a commit to carljm/cpython that referenced this issue May 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
1274e2b 
* main: (463 commits)
  pythongh-104057: Fix direct invocation of test_super (python#104064)
  pythongh-87092: Expose assembler to unit tests (python#103988)
  pythongh-97696: asyncio eager tasks factory (python#102853)
  pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054)
  pythongh-104057: Fix direct invocation of test_module (pythonGH-104059)
  pythongh-100458: Clarify Enum.__format__() change of mixed-in types in the whatsnew/3.11.rst (pythonGH-100387)
  pythongh-104018: disallow "z" format specifier in %-format of byte strings (pythonGH-104033)
  pythongh-104016: Fixed off by 1 error in f string tokenizer (python#104047)
  pythonGH-103629: Update Unpack's repr in compliance with PEP 692 (python#104048)
  pythongh-102799: replace sys.exc_info by sys.exception in inspect and traceback modules (python#104032)
  Fix typo in "expected" word in few source files (python#104034)
  pythongh-103824: fix use-after-free error in Parser/tokenizer.c (python#103993)
  pythongh-104035: Do not ignore user-defined `__{get,set}state__` in slotted frozen dataclasses (python#104041)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes topic-typing type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JelleZijlstra @franekmagiera @AlexWaygood