Skip to content

Do not skip Tkinter tests for ASAN builds if not using X11 #103707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chrstphrchvz opened this issue Apr 23, 2023 · 0 comments
Open

Do not skip Tkinter tests for ASAN builds if not using X11 #103707

chrstphrchvz opened this issue Apr 23, 2023 · 0 comments
Labels
tests Tests in the Lib/test dir topic-tkinter type-feature A feature request or enhancement

Comments

@chrstphrchvz
Copy link
Contributor

Feature or enhancement

gh-30897 skips Tkinter tests for AddressSanitizer builds due to libX11-related errors. I have not located the discussion for these errors, but I do not believe this skipping should be done for Tk on Win32 or Aqua windowing systems, as they do not use actual libX11.

I am not aware of a good way to detect the windowing system without loading Tk. Is it okay to load Tk to detect the windowing system before deciding whether to skip?
@chrstphrchvz chrstphrchvz added the type-feature A feature request or enhancement label Apr 23, 2023
@arhadthedev arhadthedev added tests Tests in the Lib/test dir topic-tkinter labels Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir topic-tkinter type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arhadthedev @chrstphrchvz