Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Tools/wasm linting and formatting issues found by ruff #103801

Closed
dversoza opened this issue Apr 24, 2023 · 0 comments
Closed

Adjust Tools/wasm linting and formatting issues found by ruff #103801

dversoza opened this issue Apr 24, 2023 · 0 comments
Assignees
@gpshead
Labels
type-feature A feature request or enhancement

Comments

@dversoza
Copy link
Contributor

dversoza commented Apr 24, 2023 •
edited by bedevere-bot
Loading

Feature or enhancement

After running ruff in CPython, some linting and formatting errors were found.
This issue intends to fix those related to the wasm module under Tools/wasm.

Pitch

In the CPython directory, we run the following command:

ruff .

We can see these three alerts under the Tools/wasm module:

Tools/wasm/wasm_assets.py:9:89: E501 Line too long (115 > 88 characters)
Tools/wasm/wasm_build.py:76:18: F541 [*] f-string without any placeholders
Tools/wasm/wasm_build.py:601:77: F841 [*] Local variable `s` is assigned to but never used

Previous discussion

None.

Linked PRs
@dversoza dversoza added the type-feature A feature request or enhancement label Apr 24, 2023
@bedevere-bot bedevere-bot mentioned this issue Apr 24, 2023
Merged
@gpshead gpshead self-assigned this Apr 24, 2023
@gpshead gpshead changed the title Adjust wasm module linting and formatting issues found by ruff Adjust Tools/wasm linting and formatting issues found by ruff Apr 24, 2023
gpshead pushed a commit that referenced this issue Apr 24, 2023
@dversoza @blurb-it
gh-103801: Tools/wasm linting and formatting (#103796)
01be52e 
This PR makes three minor linting adjustments to the `wasm` module
caught by [ruff](https://github.com/charliermarsh/ruff).

<!-- gh-issue-number: gh-103801 -->
* Issue: gh-103801
<!-- /gh-issue-number -->

---------

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
carljm added a commit to carljm/cpython that referenced this issue Apr 24, 2023
@carljm
Merge branch 'main' into superopt_spec
3236f45 
* main:
  pythongh-103801: Tools/wasm linting and formatting (python#103796)
  pythongh-103673: Add missing ForkingUnixStreamServer and ForkingUnixDatagramServer socketservers (python#103674)
  pythongh-95795: Move types.next_version_tag to PyInterpreterState (pythongh-102343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gpshead gpshead

Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gpshead @dversoza