Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 709: Crash with lambda + nested scope #104602

Closed
JelleZijlstra opened this issue May 18, 2023 · 1 comment · Fixed by #104603
Closed

PEP 709: Crash with lambda + nested scope #104602

JelleZijlstra opened this issue May 18, 2023 · 1 comment · Fixed by #104603
Assignees
Labels
type-bug An unexpected behavior, bug, or error

Comments

@JelleZijlstra
Copy link
Member

JelleZijlstra commented May 18, 2023

This crashes on main:

def a():
    def a():
        [(lambda : b) for b in [a]]
        print(b)

The original reproducer (found with my fork of https://github.com/carljm/compgenerator) was

class a:
    def a():
        class a:
            [(lambda : (a := a[(a := 2)])[b]) for b in (lambda b, a: 7)[a]]
            [][2] = b
            (1)[lambda a: a] = 4
            (2)[2] = b = a
        (4)[lambda b, a: b] = a = lambda : 1

Found in #104528 (comment) but turned out be unrelated to that PR.

Linked PRs

@JelleZijlstra
Copy link
Member Author

Further fuzzing found this case that was also fixed by #104603:

class __a:
    __a[1] = [(1) for __b in [] for __a in [lambda : __a]]

This one failed as follows:

>>> class __a:
...     __a[1] = [(1) for __b in [] for __a in [lambda : __a]]
... 
SystemError: compiler_lookup_arg(name='_a__a') with reftype=5 failed in __a; freevars of code <lambda>: ('_a__a',)

which is different from the original repro case, which segfaulted. I'll see if I can distill a useful test case out of it.

JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this issue May 19, 2023
This threw a SystemError before python#104603. Adding a separate test
because this was a different failure mode than the other two new
tests from python#104603, both of which used to segfault.
carljm pushed a commit that referenced this issue May 19, 2023
This threw a SystemError before #104603. Adding a separate test
because this was a different failure mode than the other two new
tests from #104603, both of which used to segfault.
carljm added a commit to gsallam/cpython_with_perfmap_apii that referenced this issue May 20, 2023
* main: (30 commits)
  pythongh-103987: fix several crashes in mmap module (python#103990)
  docs: fix wrong indentation causing rendering error in dis page (python#104661)
  pythongh-94906: Support multiple steps in math.nextafter (python#103881)
  pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (python#104667)
  pythongh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath (pythonGH-103842)
  pythongh-85984: New additions and improvements to the tty library. (python#101832)
  pythongh-104659: Consolidate python examples in enum documentation (python#104665)
  pythongh-92248: Deprecate `type`, `choices`, `metavar` parameters of `argparse.BooleanOptionalAction` (python#103678)
  pythongh-104645: fix error handling in marshal tests (python#104646)
  pythongh-104600: Make type.__type_params__ writable (python#104634)
  pythongh-104602: Add additional test for listcomp with lambda (python#104639)
  pythongh-104640: Disallow walrus in comprehension within type scopes (python#104641)
  pythongh-103921: Rename "type" header in argparse docs (python#104654)
  Improve readability of `typing._ProtocolMeta.__instancecheck__` (python#104649)
  pythongh-96522: Fix deadlock in pty.spawn (python#96639)
  pythonGH-102818: Do not call `PyTraceBack_Here` in sys.settrace trampoline.  (pythonGH-104579)
  pythonGH-103545: Add macOS specific constants for ``os.setpriority`` to ``os`` (python#104606)
  pythongh-104623: Update macOS installer to SQLite 3.42.0 (pythonGH-104624)
  pythongh-104619: never leak comprehension locals to outer locals() (python#104637)
  pythongh-104602: ensure all cellvars are known up front (python#104603)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants