Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mentions of old Python versions in typing.NamedTuple docstring #104943

Closed
tomasr8 opened this issue May 25, 2023 · 0 comments
Closed

Remove mentions of old Python versions in typing.NamedTuple docstring #104943

tomasr8 opened this issue May 25, 2023 · 0 comments
Labels
docs Documentation in the Doc dir topic-typing

Comments

@tomasr8
Copy link
Member

tomasr8 commented May 25, 2023 •
edited by bedevere-bot
Loading

Documentation

This came up in this PR
In typing.NamedTuple there are some mentions to Python 3.5 & 3.6 which can be removed:

cpython/Lib/typing.py

Line 2712 in bd1b622

Usage in Python versions >= 3.6::

cpython/Lib/typing.py

Lines 2729 to 2731 in bd1b622

In Python versions <= 3.5 use::
Employee = NamedTuple('Employee', [('name', str), ('id', int)])

Linked PRs
@tomasr8 tomasr8 added the docs Documentation in the Doc dir label May 25, 2023
@bedevere-bot bedevere-bot mentioned this issue May 25, 2023
Merged
hauntsaninja pushed a commit that referenced this issue May 26, 2023
@tomasr8
gh-104943: Remove mentions of old Python versions (#104945)
46857d0
@bedevere-bot bedevere-bot mentioned this issue May 26, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 26, 2023
@tomasr8 @miss-islington
pythongh-104943: Remove mentions of old Python versions (pythonGH-104945
da3a3d0 
)

(cherry picked from commit 46857d0)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue May 26, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 26, 2023
@tomasr8 @miss-islington
pythongh-104943: Remove mentions of old Python versions (pythonGH-104945
b0c9bfa 
)

(cherry picked from commit 46857d0)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
hauntsaninja pushed a commit that referenced this issue May 26, 2023
@miss-islington @tomasr8
[3.11] gh-104943: Remove mentions of old Python versions (GH-104945) (#…
1342474 
…104962)

(cherry picked from commit 46857d0)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
hauntsaninja pushed a commit that referenced this issue May 26, 2023
@miss-islington @tomasr8
[3.12] gh-104943: Remove mentions of old Python versions (GH-104945) (#…
6324458 
…104963)

(cherry picked from commit 46857d0)

Co-authored-by: Tomas R <tomas.roun8@gmail.com>
@erlend-aasland erlend-aasland mentioned this issue Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir topic-typing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sobolevn @tomasr8 @AlexWaygood