-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stable_abi.py --all fails on Windows #105091
Comments
@AlexWaygood Could you wrap cpython/Tools/build/stable_abi.py Line 687 in bd98b65
if UNIXY: and check if it solves the issue?
|
Yup, this fixes things on my machine! --- a/Tools/build/stable_abi.py
+++ b/Tools/build/stable_abi.py
@@ -684,7 +684,8 @@ def main():
if args.all:
run_all_generators = True
- args.unixy_check = True
+ if UNIXY:
+ args.unixy_check = True
try:
file = args.file.open('rb') |
encukou
added a commit
to encukou/cpython
that referenced
this issue
May 30, 2023
encukou
added a commit
that referenced
this issue
May 30, 2023
carljm
added a commit
to carljm/cpython
that referenced
this issue
May 30, 2023
* main: CI: Temporarily skip paths with spaces to avoid error (python#105110) pythongh-105071: add missing versionadded directive (python#105097) pythongh-80064: Fix is_valid_wide_char() return type (python#105099) Small speedup for dataclass __eq__ and __repr__ (python#104904) pythongh-103921: Minor PEP-695 fixes to the `ast` module docs (python#105093) pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (pythonGH-105092)
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
May 31, 2023
…her platforms (pythonGH-105092) (cherry picked from commit 0656d23) Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou
added a commit
that referenced
this issue
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
--all
command from the devguide fails on Windows.--all
should only enableunixy_check
on Unixy platforms.Linked PRs
The text was updated successfully, but these errors were encountered: