Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable_abi.py --all fails on Windows #105091

Closed
encukou opened this issue May 30, 2023 · 2 comments
Closed

stable_abi.py --all fails on Windows #105091

encukou opened this issue May 30, 2023 · 2 comments
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@encukou
Copy link
Member

encukou commented May 30, 2023

The --all command from the devguide fails on Windows.

--all should only enable unixy_check on Unixy platforms.

Linked PRs

@encukou encukou added type-bug An unexpected behavior, bug, or error build The build process and cross-build labels May 30, 2023
@encukou
Copy link
Member Author

encukou commented May 30, 2023

@AlexWaygood Could you wrap

args.unixy_check = True
in if UNIXY: and check if it solves the issue?

@AlexWaygood
Copy link
Member

@AlexWaygood Could you wrap

args.unixy_check = True

in if UNIXY: and check if it solves the issue?

Yup, this fixes things on my machine!

--- a/Tools/build/stable_abi.py
+++ b/Tools/build/stable_abi.py
@@ -684,7 +684,8 @@ def main():

     if args.all:
         run_all_generators = True
-        args.unixy_check = True
+        if UNIXY:
+            args.unixy_check = True

     try:
         file = args.file.open('rb')

encukou added a commit to encukou/cpython that referenced this issue May 30, 2023
@encukou encukou closed this as completed May 30, 2023
carljm added a commit to carljm/cpython that referenced this issue May 30, 2023
* main:
  CI: Temporarily skip paths with spaces to avoid error (python#105110)
  pythongh-105071: add missing versionadded directive (python#105097)
  pythongh-80064: Fix is_valid_wide_char() return type (python#105099)
  Small speedup for dataclass __eq__ and __repr__ (python#104904)
  pythongh-103921: Minor PEP-695 fixes to the `ast` module docs (python#105093)
  pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (pythonGH-105092)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 31, 2023
…her platforms (pythonGH-105092)

(cherry picked from commit 0656d23)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou added a commit that referenced this issue May 31, 2023
…ther platforms (GH-105092) (GH-105133)

gh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (GH-105092)
(cherry picked from commit 0656d23)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

2 participants