Skip to content

Modules/_sha3 is created by configure, but no longer an actual source directory #106123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smontanaro opened this issue Jun 26, 2023 · 0 comments
Closed

Modules/_sha3 is created by configure, but no longer an actual source directory #106123

smontanaro opened this issue Jun 26, 2023 · 0 comments
Labels
type-bug An unexpected behavior, bug, or error

Comments

@smontanaro
Copy link
Contributor

smontanaro commented Jun 26, 2023 •
edited by bedevere-bot
Loading

Bug report

I noticed that make distclean didn't compare correctly with a fresh clone (after accounting for files I expected it wouldn't be expected to clean up). It left an empty Modules/_sha3 directory which used to hold files, but which is simply created by configure, then ignored.

Your environment

  • main branch
  • MacOS Ventura 13.4.1, Apple M1

Linked PRs
@smontanaro smontanaro added the type-bug An unexpected behavior, bug, or error label Jun 26, 2023
@bedevere-bot bedevere-bot mentioned this issue Jun 26, 2023
Merged
hauntsaninja pushed a commit that referenced this issue Jun 27, 2023
@smontanaro
gh-106123: Modules/_sha3 appears to no longer be necessary (#106124)
0345b0c
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 27, 2023
@smontanaro @miss-islington
pythongh-106123: Modules/_sha3 appears to no longer be necessary (pyt…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1ae5868 
…honGH-106124)

(cherry picked from commit 0345b0c)

Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
@bedevere-bot bedevere-bot mentioned this issue Jun 27, 2023
Merged
hauntsaninja pushed a commit that referenced this issue Jun 27, 2023
@miss-islington @smontanaro
[3.12] gh-106123: Modules/_sha3 appears to no longer be necessary (GH…
0efbe4d 
…-106124) (#106127)

Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smontanaro @hauntsaninja