Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asyncio._SelectorSocketTransport cyclic ref leak is back as ._write_ready.__self__ #106503

Closed
pteromys opened this issue Jul 7, 2023 · 1 comment
Closed

asyncio._SelectorSocketTransport cyclic ref leak is back as ._write_ready.__self__ #106503

pteromys opened this issue Jul 7, 2023 · 1 comment
Labels
topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@pteromys
Copy link
Contributor

pteromys commented Jul 7, 2023 •
edited by bedevere-bot
Loading

Bug report

#100348 aka #87745 (fix #100349 merged 2022-12-20) is back as a side effect of #31871 (merged 2022-12-24)—caching a bound method as _write_ready creates the reference cycle ._write_ready.__self__ on _SelectorSocketTransport.

Your environment

  • CPython versions tested on: 3.9.12, 3.11.3
  • Operating system and architecture: uname -a = Linux delia 6.3.2-arch1-1 #1 SMP PREEMPT_DYNAMIC Thu, 11 May 2023 16:40:42 +0000 x86_64 GNU/Linux

Linked PRs
@pteromys pteromys added the type-bug An unexpected behavior, bug, or error label Jul 7, 2023
@github-project-automation github-project-automation bot moved this to Todo in asyncio Jul 7, 2023
@bedevere-bot bedevere-bot mentioned this issue Jul 7, 2023
Merged
kumaraditya303 pushed a commit that referenced this issue Jul 7, 2023
@pteromys
gh-106503: asyncio._SelectorSocketTransport: fix cyclic reference on …
3e5ce79 
…close(). (#106504)
@bedevere-bot bedevere-bot mentioned this issue Jul 7, 2023
Merged
kumaraditya303 pushed a commit that referenced this issue Jul 7, 2023
@miss-islington @pteromys
[3.12] gh-106503: asyncio._SelectorSocketTransport: fix cyclic refere…
7e883d7 
…nce on close(). (GH-106504) (#106514)

gh-106503: asyncio._SelectorSocketTransport: fix cyclic reference on close(). (GH-106504)
(cherry picked from commit 3e5ce79)

Co-authored-by: Andrew Geng <pteromys@gmail.com>
@pteromys
Copy link
Contributor Author

pteromys commented Jul 7, 2023

Closed by PRs #106504 (main) and #106514 (3.12 backport).

@pteromys pteromys closed this as completed Jul 7, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in asyncio Jul 7, 2023
Tasssadar added a commit to Tasssadar/cpython that referenced this issue Dec 17, 2024
@Tasssadar
Fix incomplete writes after close in asyncio._SelectorSocketTransport
fe8b79c 
Change introduced in pythongh-106503 cause the transport to miss writes
scheduled after it is closed.

Signed-off-by: Vojtěch Boček <vbocek@gmail.com>
@Tasssadar Tasssadar mentioned this issue Dec 17, 2024
Merged
Tasssadar added a commit to Tasssadar/cpython that referenced this issue Dec 17, 2024
@Tasssadar
Fix incomplete writes after close in asyncio._SelectorSocketTransport
113440a 
Change introduced in pythongh-106503 cause the transport to miss writes
scheduled after it is closed.

Signed-off-by: Vojtěch Boček <vbocek@gmail.com>
Tasssadar added a commit to Tasssadar/cpython that referenced this issue Dec 17, 2024
@Tasssadar
Fix incomplete writes after close in asyncio._SelectorSocketTransport
f727b51 
Change introduced in pythongh-106503 cause the transport to miss writes
scheduled after it is closed.

Signed-off-by: Vojtěch Boček <vbocek@gmail.com>
Tasssadar added a commit to Tasssadar/cpython that referenced this issue Jan 13, 2025
@Tasssadar
Fix incomplete writes after close in asyncio._SelectorSocketTransport
060cba1 
Change introduced in pythongh-106503 cause the transport to miss writes
scheduled after it is closed.

Signed-off-by: Vojtěch Boček <vbocek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-asyncio type-bug An unexpected behavior, bug, or error
Projects
asyncio
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pteromys @AlexWaygood