Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tok_report_warnings in tokenizer state is not needed #106989

Closed
lysnikolaou opened this issue Jul 22, 2023 · 1 comment
Closed

tok_report_warnings in tokenizer state is not needed #106989

lysnikolaou opened this issue Jul 22, 2023 · 1 comment
Labels
3.13 bugs and security fixes easy interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@lysnikolaou
Copy link
Member

lysnikolaou commented Jul 22, 2023 •
edited by bedevere-bot
Loading

When we merged PEP 701, we added tok_report_warnings, which apparently got in by accident. The issue it was trying to solve was already resolved in #99891 and #99893. I think that it can safely removed both from the tokenizer struct and all occurences should be changed to use report_warnings instead.

Linked PRs
@lysnikolaou lysnikolaou added type-bug An unexpected behavior, bug, or error easy 3.13 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 22, 2023
@menkotoglou
Copy link
Contributor

I can work on this, during the EuroPython 2023 sprints.

@bedevere-bot bedevere-bot mentioned this issue Jul 22, 2023
Merged
pablogsal pushed a commit that referenced this issue Jul 22, 2023
@menkotoglou
gh-106989: Remove tok report warnings (#106993)
76e20c3
@bedevere-bot bedevere-bot mentioned this issue Jul 22, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 22, 2023
@menkotoglou @miss-islington
pythongh-106989: Remove tok report warnings (pythonGH-106993)
d72e981 
(cherry picked from commit 76e20c3)

Co-authored-by: Menelaos Kotoglou <contact@menelaoskotoglou.com>
pablogsal pushed a commit that referenced this issue Jul 22, 2023
@miss-islington @menkotoglou
[3.12] gh-106989: Remove tok report warnings (GH-106993) (#107013)
b6ace75 
Co-authored-by: Menelaos Kotoglou <contact@menelaoskotoglou.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes easy interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pablogsal @lysnikolaou @menkotoglou