Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronise the signature of sqlite3.connect? and sqlite3.Connection.__init__` #107938

Closed
erlend-aasland opened this issue Aug 14, 2023 · 0 comments
Closed

Synchronise the signature of sqlite3.connect? and sqlite3.Connection.__init__` #107938

erlend-aasland opened this issue Aug 14, 2023 · 0 comments
Assignees
@erlend-aasland
Labels
topic-sqlite3

Comments

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Aug 14, 2023 •
edited by bedevere-bot
Loading

See #93057 (comment):

[...] we have some technical dept when it comes to sqlite3.connect and sqlite3.Connection.__init__. Currently, the latter uses clinic, and the former does not use clinic. However, it is sqlite3.connect that needs the docstring, not sqlite3.Connection.__init__. We should make it so that the docstring from sqlite3.Connection.__init__ is used for sqlite3.connect and output to a separate file, for inclusion by Module/_sqlite/module.c.

Previously, the two argument specs needed to be kept in sync manually. Some fairly recent changes improved this, but we still need to keep the docstring and methoddef of sqlite3.connect up to date manually.

Linked PRs
@bedevere-bot bedevere-bot mentioned this issue Aug 14, 2023
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 14, 2023
@erlend-aasland
pythongh-107938: Synchonise the signature of of sqlite3.connect and s…
1311124 
…qlite3.Connection.__init__
@erlend-aasland erlend-aasland self-assigned this Aug 14, 2023
erlend-aasland added a commit that referenced this issue Aug 14, 2023
@erlend-aasland
gh-107938: Synchonise the signature of of sqlite3.connect and sqlite3…
6fbaba5 
….Connection.__init__ (#107939)
@bedevere-bot bedevere-bot mentioned this issue Aug 14, 2023
Closed
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 14, 2023
@erlend-aasland @miss-islington
pythongh-107938: Synchonise the signature of of sqlite3.connect and s…
c3a841b 
…qlite3.Connection.__init__ (pythonGH-107939)

(cherry picked from commit 6fbaba5)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot bedevere-bot mentioned this issue Aug 14, 2023
Closed
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 14, 2023
@erlend-aasland
[3.11] pythongh-107938: Synchonise the signature of of sqlite3.connec…
1452a8a 
…t and sqlite3.Connection.__init__ (python#107939)

(cherry picked from commit 6fbaba5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
topic-sqlite3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erlend-aasland