Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate entry in 3.11.5 changelog - pickle module #108542

Closed
salty-horse opened this issue Aug 27, 2023 · 2 comments · Fixed by #108543
Closed

Duplicate entry in 3.11.5 changelog - pickle module #108542

salty-horse opened this issue Aug 27, 2023 · 2 comments · Fixed by #108543
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@salty-horse
Copy link
Contributor

salty-horse commented Aug 27, 2023 •
edited by bedevere-bot
Loading

Documentation

The 3.11.5 changelog has an entry that appears twice:

gh-105375: Fix bugs in pickle where exceptions could be overwritten.
gh-105497: Fix flag inversion when alias/mask members exist.
gh-105375: Fix bugs in pickle where exceptions could be overwritten.

The relevant files with identical contents:
Misc/NEWS.d/next/Library/2023-06-08-08-58-36.gh-issue-105375.bTcqS9.rst
Misc/NEWS.d/next/Library/2023-06-09-21-04-39.gh-issue-105375.bTcqS9.rst

Linked PRs
@salty-horse salty-horse added the docs Documentation in the Doc dir label Aug 27, 2023
@Eclips4
Copy link
Member

Eclips4 commented Aug 27, 2023

Yeah, Misc/NEWS.d/next/Library/2023-06-09-21-04-39.gh-issue-105375.bTcqS9.rst has incorrect information. There's should be "Fix bugs in errno where exceptions could be overwritten."

Would you like to send a PR?

salty-horse added a commit to salty-horse/cpython that referenced this issue Aug 27, 2023
@salty-horse
Docs: Fix bad module name in 3.11.5 changelog entry (pythongh-108542)
f087c6e
@salty-horse salty-horse mentioned this issue Aug 27, 2023
Merged
@erlend-aasland
Copy link
Contributor

FTR, the NEWS entry comes from eede1d2, PR gh-105590, issue gh-105375. The NEWS entry is present in main, 3.12, and 3.11.

@erlend-aasland erlend-aasland added 3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes type-bug An unexpected behavior, bug, or error labels Aug 27, 2023
erlend-aasland pushed a commit that referenced this issue Aug 27, 2023
@salty-horse
gh-108542: Fix incorrect module name in NEWS entry for gh-105475 (#10…
a429eaf 
…8543)
This was referenced Aug 27, 2023
Merged
Merged
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 27, 2023
@erlend-aasland
[3.12] pythongh-108542: Fix incorrect module name in NEWS entry for p…
9875beb 
…ythongh-105475 (python#108543)

(cherry picked from commit a429eaf)
erlend-aasland added a commit that referenced this issue Aug 27, 2023
@erlend-aasland
[3.11] gh-108542: Fix incorrect module name in NEWS entry for gh-105475…
73f89b1 
… (#108543) (#108544)

(cherry picked from commit a429eaf)
Yhg1s pushed a commit that referenced this issue Aug 27, 2023
@erlend-aasland
[3.12] gh-108542: Fix incorrect module name in NEWS entry for gh-105475…
32d48ed 
… (#108543) (#108545)

(cherry picked from commit a429eaf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-108542: Fix incorrect module name in NEWS entry for gh-105475 salty-horse/cpython
3 participants
@salty-horse @erlend-aasland @Eclips4