Skip to content

Use Kyiv instead of Kiev in test_email #109017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jspricke opened this issue Sep 6, 2023 · 3 comments
Closed

Use Kyiv instead of Kiev in test_email #109017

jspricke opened this issue Sep 6, 2023 · 3 comments
Assignees
@serhiy-storchaka
Labels
type-bug An unexpected behavior, bug, or error

Comments

@jspricke
Copy link
Contributor

jspricke commented Sep 6, 2023 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

As proposed in #108533 the time zone was renamed but we can't simply rename it in the test cause it fails on old(?) MacOS systems. I would propose to prepend it with:

@unittest.skipUnless(os.path.exists('/usr/share/zoneinfo/Europe/Kyiv') or
                         os.path.exists('/usr/lib/zoneinfo/Europe/Kyiv'),
                         "Can't find the Olson's TZ database")

CPython versions tested on:

3.11

Operating systems tested on:

Linux

Linked PRs
@jspricke jspricke added the type-bug An unexpected behavior, bug, or error label Sep 6, 2023
@corona10
Copy link
Member

@serhiy-storchaka Would you like to take a look since you are the Ukranian?

jspricke added a commit to jspricke/cpython that referenced this issue Sep 11, 2023
@jspricke
Use non alternate name for Kyiv (Fixes: python#109017)
9026723 
tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
jspricke added a commit to jspricke/cpython that referenced this issue Sep 11, 2023
@jspricke
pythongh-109017: Use non alternate name for Kyiv
43a38cf 
tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
@bedevere-bot bedevere-bot mentioned this issue Sep 11, 2023
Merged
@serhiy-storchaka serhiy-storchaka self-assigned this Sep 11, 2023
@serhiy-storchaka
Copy link
Member

I do not like relying on the particular location of the database. Although it was already here in the existing code, the comment notes that it is not a robust way. Now we have zoneinfo in the stdlib, so perhaps it could be used.

jspricke added a commit to jspricke/cpython that referenced this issue Sep 11, 2023
@jspricke
pythongh-109017: Use non alternate name for Kyiv
f7545ea 
tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
@jspricke
Copy link
Contributor Author

@serhiy-storchaka thanks for the proposal, I've updated my PR.

jspricke added a commit to jspricke/cpython that referenced this issue Sep 11, 2023
@jspricke
pythongh-109017: Use non alternate name for Kyiv
b10798b 
tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
serhiy-storchaka pushed a commit that referenced this issue Oct 24, 2023
@jspricke
gh-109017: Use non alternate name for Kyiv (GH-109251)
46407fe 
tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 24, 2023
@jspricke @miss-islington
pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)
59db316 
tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
(cherry picked from commit 46407fe)

Co-authored-by: Jochen Sprickerhof <github@jochen.sprickerhof.de>
@bedevere-app bedevere-app bot mentioned this issue Oct 24, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Oct 24, 2023
@jspricke @miss-islington
pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)
1b56294 
tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
(cherry picked from commit 46407fe)

Co-authored-by: Jochen Sprickerhof <github@jochen.sprickerhof.de>
@bedevere-app bedevere-app bot mentioned this issue Oct 24, 2023
Merged
serhiy-storchaka pushed a commit that referenced this issue Oct 24, 2023
@miss-islington @jspricke
[3.12] gh-109017: Use non alternate name for Kyiv (GH-109251) (GH-111280
b6e508c 
)

tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
(cherry picked from commit 46407fe)

Co-authored-by: Jochen Sprickerhof <github@jochen.sprickerhof.de>
serhiy-storchaka pushed a commit that referenced this issue Oct 24, 2023
@miss-islington @jspricke
[3.11] gh-109017: Use non alternate name for Kyiv (GH-109251) (GH-111279
652d3f3 
)

tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
(cherry picked from commit 46407fe)

Co-authored-by: Jochen Sprickerhof <github@jochen.sprickerhof.de>
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@jspricke @aisk
pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)
ac32394 
tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@jspricke @Glyphack
pythongh-109017: Use non alternate name for Kyiv (pythonGH-109251)
8fbaa03 
tzdata provides Kiev as an alternative to Kyiv:
https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314#L314

But Debian moved it to the tzdata-legacy package breaking the test:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.

Also check that the new name is actually available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serhiy-storchaka serhiy-storchaka

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jspricke @serhiy-storchaka @corona10