Skip to content

Move test.test_import._ready_to_import helper to test.support.import_helper #109625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Sep 20, 2023 · 2 comments
Closed

Move test.test_import._ready_to_import helper to test.support.import_helper #109625

sobolevn opened this issue Sep 20, 2023 · 2 comments
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@sobolevn
Copy link
Member

sobolevn commented Sep 20, 2023 •
edited by bedevere-app bot
Loading

Feature or enhancement

It is used in test_import and test_inspect, right now test_inspect has to import test_import to use this function. Since we try to reduce the amount of test cross-dependencies, it is better to move it to the designated support module.

Refs #109607

Linked PRs
@sobolevn sobolevn added type-feature A feature request or enhancement tests Tests in the Lib/test dir labels Sep 20, 2023
@sobolevn sobolevn self-assigned this Sep 20, 2023
sobolevn added a commit to sobolevn/cpython that referenced this issue Sep 20, 2023
@sobolevn
pythongh-109625: Move _ready_to_import from test_import to `impor…
e1b40d4 
…t_helper`
@bedevere-app bedevere-app bot mentioned this issue Sep 20, 2023
Merged
sobolevn added a commit to sobolevn/cpython that referenced this issue Sep 20, 2023
@sobolevn
pythongh-109625: Move _ready_to_import from test_import to `impor…
4839fd4 
…t_helper`
vstinner pushed a commit that referenced this issue Sep 21, 2023
@sobolevn
gh-109625: Move _ready_to_import() from test_import to support.import…
115c49a 
…_helper (#109626)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Sep 21, 2023
@sobolevn @miss-islington
pythongh-109625: Move _ready_to_import() from test_import to support.…
1e40c02 
…import_helper (pythonGH-109626)

(cherry picked from commit 115c49a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app bedevere-app bot mentioned this issue Sep 21, 2023
Merged
sobolevn added a commit to sobolevn/cpython that referenced this issue Sep 22, 2023
@sobolevn
[3.11] pythongh-109625: Move _ready_to_import() from test_import to s…
752e96f 
…upport.import_helper (pythonGH-109626).

(cherry picked from commit 115c49a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app bedevere-app bot mentioned this issue Sep 22, 2023
Merged
vstinner pushed a commit that referenced this issue Sep 22, 2023
@sobolevn
[3.11] gh-109625: Move _ready_to_import() from test_import to support…
f45ef5e 
….import_helper (GH-109626) (#109718)

[3.11] gh-109625: Move _ready_to_import() from test_import to support.import_helper (GH-109626).
(cherry picked from commit 115c49a)
csm10495 pushed a commit to csm10495/cpython that referenced this issue Sep 28, 2023
@sobolevn @csm10495
pythongh-109625: Move _ready_to_import() from test_import to support.…
4806a15 
…import_helper (python#109626)
Yhg1s pushed a commit that referenced this issue Oct 2, 2023
@miss-islington @sobolevn
[3.12] gh-109625: Move _ready_to_import() from test_import to support…
8c5fd21 
….import_helper (GH-109626) (#109640)

gh-109625: Move _ready_to_import() from test_import to support.import_helper (GH-109626)
(cherry picked from commit 115c49a)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@hugovk
Copy link
Member

hugovk commented Nov 9, 2023

Thanks!

@hugovk hugovk closed this as completed Nov 9, 2023
@hugovk
Copy link
Member

hugovk commented Nov 9, 2023

Thanks!

Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@sobolevn @Glyphack
pythongh-109625: Move _ready_to_import() from test_import to support.…
33a6b9e 
…import_helper (python#109626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hugovk @sobolevn