Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to reduce code duplication in Tools/scripts/summarize_stats.py #110019

Closed
mdboom opened this issue Sep 28, 2023 · 1 comment
Closed

Refactor to reduce code duplication in Tools/scripts/summarize_stats.py #110019

mdboom opened this issue Sep 28, 2023 · 1 comment
Assignees
Labels
type-feature A feature request or enhancement

Comments

@mdboom
Copy link
Contributor

mdboom commented Sep 28, 2023

Feature or enhancement

Proposal:

The summarize_stats.py script operates in two modes: single and comparison. It grew these two modes somewhat organically, and there is a lot of code duplication and opportunity for these two modes to diverge. By refactoring to have each of the tables know how to present themselves in both modes, we should reduce the overall amount of code and these kinds of bugs. This refactor should be helpful in advance of the many new stats we plan to add for the Tier 2 interpreter.

Cc: @brandtbucher, @markshannon

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

Related: #109329

Linked PRs

@mdboom mdboom added the type-feature A feature request or enhancement label Sep 28, 2023
@mdboom mdboom self-assigned this Sep 28, 2023
mdboom added a commit to mdboom/cpython that referenced this issue Oct 5, 2023
This refactors summarize_stats so that the comparative tables are easier
to make and use more common code.
mdboom added a commit to mdboom/cpython that referenced this issue Oct 5, 2023
This refactors summarize_stats so that the comparative tables are easier
to make and use more common code.
@hugovk
Copy link
Member

hugovk commented Nov 9, 2023

Thanks!

@hugovk hugovk closed this as completed Nov 9, 2023
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants