Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--disable-gil test failures due to ABI flag #110119

Closed
Tracked by #108219
colesbury opened this issue Sep 29, 2023 · 6 comments
Closed
Tracked by #108219

--disable-gil test failures due to ABI flag #110119

colesbury opened this issue Sep 29, 2023 · 6 comments
Assignees
@colesbury
Labels
3.13 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@colesbury
Copy link
Contributor

colesbury commented Sep 29, 2023 •
edited by bedevere-app bot
Loading

Bug report

On Linux and macOS, test_cppext fails due to:

AssertionError: would build wheel with unsupported tag ('cp313', 'cp313td', 'linux_x86_64')

Example build: https://buildbot.python.org/all/#/builders/1217/builds/286

Resolving this failure will require updating pip and our bundled pip version. In the meantime, I will skip this test on --disable-gil builds.

On Windows, there are additional build failures (test_importlib, test_peg_generator)

AssertionError: '_d.cp313-win32.pyd' not found in ['_d.cp313t-win_amd64.pyd', '_d.pyd']

LINK : fatal error LNK1181: cannot open input file 'python313_d.lib'

Example build: https://buildbot.python.org/all/#/builders/1241/builds/18

Resolving the Windows test failures require #110049 so that we have a standard way of determining --disable-gil builds from Python code.

Linked PRs
@colesbury colesbury added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir 3.13 bugs and security fixes labels Sep 29, 2023
@colesbury colesbury self-assigned this Sep 29, 2023
@colesbury colesbury mentioned this issue Sep 29, 2023
Open
colesbury added a commit to colesbury/cpython that referenced this issue Sep 29, 2023
@colesbury
pythongh-110119: Temporarily skip test_cppext on --disable-gil builds.
d071615 
The current version of pip does not support "t" in the ABI flags. Skip
the test in `--disable-gil` builds until we can update pip.
@colesbury colesbury mentioned this issue Sep 29, 2023
Merged
@bedevere-app bedevere-app bot mentioned this issue Sep 29, 2023
Merged
carljm pushed a commit that referenced this issue Sep 29, 2023
@colesbury
gh-110119: Temporarily skip test_cppext on --disable-gil builds. (#11…
2973970 
…0123)

The current version of pip does not support "t" in the ABI flags. Skip
the test in `--disable-gil` builds until we can update pip.
colesbury added a commit to colesbury/cpython that referenced this issue Oct 5, 2023
@colesbury
pythongh-110119: Fix test_importlib --disable-gil Windows test fail…
2ebec1f 
…ures

Use "t" in the expected tag for `--disable-gil` builds in test_tagged_suffix.
@bedevere-app bedevere-app bot mentioned this issue Oct 5, 2023
Merged
vstinner pushed a commit that referenced this issue Oct 5, 2023
@colesbury
gh-110119: Fix test_importlib --disable-gil Windows test failures (#…
3c2f321 
…110422)

Use "t" in the expected tag for `--disable-gil` builds in test_tagged_suffix.
@colesbury
Copy link
Contributor Author

These are fixed now. The Windows buildbot needed to not be run from the "Developer Command Prompt for VS 2022".

@colesbury
Copy link
Contributor Author

Oops I was looking at the wrong green icon.

@colesbury colesbury reopened this Oct 5, 2023
@vstinner
Copy link
Member

vstinner commented Oct 5, 2023

[test_cppext] Resolving this failure will require updating pip and our bundled pip version. In the meantime, I will skip this test on --disable-gil builds.

If pip is fixed, can the test upgrade pip if running NoGIL Python, as a temporary workaround?

@colesbury
Copy link
Contributor Author

Pip's not fixed yet, but that might be possible once it's fixed. I just put up a PR pypa/packaging#728 to update packaging.tags and then that would need to be pulled into pip's vendored copy of packaging.

@vstinner
Copy link
Member

vstinner commented Oct 6, 2023

Until pip is fixed, sure, you can skip test_cppext on NoGIL build.

@colesbury
Copy link
Contributor Author

The Windows test looks like it's passing now.

colesbury added a commit to colesbury/cpython that referenced this issue Mar 18, 2024
@colesbury
Revert "pythongh-110119: Temporarily skip test_cppext on --disable-gi…
a74c8da 
…l builds. (python#110123)"

The `test_cppext` can run now that the `wheel` package is updated.

This reverts commit 2973970.
@bedevere-app bedevere-app bot mentioned this issue Mar 18, 2024
Closed
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@colesbury @Glyphack
pythongh-110119: Temporarily skip test_cppext on --disable-gil builds. (
fd3b9da 
python#110123)

The current version of pip does not support "t" in the ABI flags. Skip
the test in `--disable-gil` builds until we can update pip.
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@colesbury @Glyphack
pythongh-110119: Fix test_importlib --disable-gil Windows test fail…
d2501d2 
…ures (python#110422)

Use "t" in the expected tag for `--disable-gil` builds in test_tagged_suffix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colesbury colesbury

Labels
3.13 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vstinner @colesbury