Skip to content

Create test_termios.py #110380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue Oct 5, 2023 · 1 comment
Closed

Create test_termios.py #110380

sobolevn opened this issue Oct 5, 2023 · 1 comment
Assignees
@sobolevn
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@sobolevn
Copy link
Member

sobolevn commented Oct 5, 2023 •
edited by github-actions bot
Loading

Feature or enhancement

In #110366 we found several bugs in termios.c module.
But, right now they are not tested.

I propose to add a new test file that can at least cover some regressions that are easy to do.
For example, checking error overwrite or crash from #110366

It is better than nothing, later people more familiar with termios can add more tests and infrastructure to test more advanced things.

I am working on the PR. Expect it tomorrow or something.
@sobolevn sobolevn added type-feature A feature request or enhancement tests Tests in the Lib/test dir labels Oct 5, 2023
@sobolevn sobolevn self-assigned this Oct 5, 2023
@sobolevn sobolevn mentioned this issue Oct 5, 2023
Merged
@AlexWaygood
Copy link
Member

Duplicate of #81002

@AlexWaygood AlexWaygood marked this as a duplicate of #81002 Oct 5, 2023
@AlexWaygood AlexWaygood closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @AlexWaygood