Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions job that runs the tests in an installed Python #110793

Open
FFY00 opened this issue Oct 13, 2023 · 0 comments
Open

Add GitHub Actions job that runs the tests in an installed Python #110793

FFY00 opened this issue Oct 13, 2023 · 0 comments
Labels
type-feature A feature request or enhancement

Comments

@FFY00
Copy link
Member

FFY00 commented Oct 13, 2023

Feature or enhancement

Proposal:

Ugh, I have tripped into this again... I have a PR with all the tests green on Github, but the Python installation is pretty much broken because I forgot to update something on the build system.

My latest example is GH-110785, which causes the sysconfig module to be missing after installing. The breakage was caught by the buildbots, which is good, but we should not be able to merge something into main that causes such major breakage, and still, I don't feel very confident with only two buildbots failing.

I think we should have a job on Github that installs Python and runs the tests using that installation.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

@FFY00 FFY00 added the type-feature A feature request or enhancement label Oct 13, 2023
FFY00 added a commit to FFY00/cpython that referenced this issue Oct 13, 2023
Signed-off-by: Filipe Laíns <lains@riseup.net>
@hugovk hugovk changed the title Add Github actions job that runs the tests in an installed Python Add GitHub Actions job that runs the tests in an installed Python Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant