Skip to content

test_repr_deep from test_userdict triggers stack overflow protections for a debug build under WASI #111809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brettcannon opened this issue Nov 7, 2023 · 3 comments
Closed

test_repr_deep from test_userdict triggers stack overflow protections for a debug build under WASI #111809

brettcannon opened this issue Nov 7, 2023 · 3 comments
Labels
OS-wasi

Comments

@brettcannon
Copy link
Member

brettcannon commented Nov 7, 2023 •
edited by bedevere-app bot
Loading

Detected with WASI-SDK 20 and wasmtime 14.

Linked PRs
@sobolevn sobolevn mentioned this issue Nov 7, 2023
Merged
@brettcannon
Copy link
Member Author

FYI @sobolevn plans to tackle this.

@sobolevn
Copy link
Member

sobolevn commented Nov 8, 2023

@brettcannon indeed :)

What is interesting is that test_dict does not fail, does it?
It is basically the same test with a different type.

@brettcannon
Copy link
Member Author

What is interesting is that test_dict does not fail, does it?

It passes.

It is basically the same test with a different type.

But it's a different data structure. And there are different stack depths for C calls compared to Python calls.

sobolevn added a commit to sobolevn/cpython that referenced this issue Nov 18, 2023
@sobolevn
pythongh-111809: Fix test_deep_repr from test_userdict on WASI
8bb9aca
@bedevere-app bedevere-app bot mentioned this issue Nov 18, 2023
Merged
brettcannon pushed a commit that referenced this issue Nov 22, 2023
@sobolevn
gh-111809: Fix test_deep_repr from test_userdict on WASI (GH-112229)
14e539f
@github-project-automation github-project-automation bot moved this from Todo to Done in WASI to tier 2 Nov 22, 2023
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@sobolevn @aisk
pythongh-111809: Fix test_deep_repr from test_userdict on WASI (p…
d5722b6 
…ythonGH-112229)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@sobolevn @Glyphack
pythongh-111809: Fix test_deep_repr from test_userdict on WASI (p…
40e2af3 
…ythonGH-112229)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-wasi
Projects
No open projects
WASI to tier 2
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @sobolevn