Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Py_NOGIL to a positive term #111863

Closed
hugovk opened this issue Nov 8, 2023 · 7 comments
Closed

Rename Py_NOGIL to a positive term #111863

hugovk opened this issue Nov 8, 2023 · 7 comments
Labels
3.13 bugs and security fixes topic-free-threading

Comments

@hugovk
Copy link
Member

hugovk commented Nov 8, 2023

From the PEP 703 acceptance:

We want to avoid negatives in terms and flags and such, so we won’t get into double-negative terrain (like we do when we talk about ‘non no-GIL’). We’d like a positive, clear term to talk about the no-GIL build, and we’re suggesting ‘free-threaded’. (Relatedly, that’s why the build mode/ABI letter is ‘t’ and not ‘n’; that change was already made.)

Py_NOGIL is a user-facing macro, let's rename it to something positive.

Maybe Py_DISABLE_GIL or Py_FREE_THREADED?

cc @colesbury

Linked PRs

@corona10
Copy link
Member

corona10 commented Nov 8, 2023

Maybe it will affect to #111571, Sam may need to make decision what should go first :)
But I agree with updating the term to follow SC's decision anyway.

@hugovk
Copy link
Member Author

hugovk commented Nov 8, 2023

Yep, fully defer to Sam to merge things in whatever order he likes, including closing #111864 if he wants to do it another way.

@itamaro
Copy link
Contributor

itamaro commented Nov 9, 2023

up to Sam of course, but perhaps invert it completely, and go with something like Py_GIL or Py_WITH_GIL?

@colesbury
Copy link
Contributor

I commented on @hugovk's PR (#111864 (comment)).

Macros like Py_GIL or Py_WITH_GIL do not work well because they are not defined in older versions of Python (or pypy). That would make writing the #if pre-processor guards more difficult for extension code that targets multiple versions of Python.

@colesbury
Copy link
Contributor

I put an issue in the steering council GitHub repo: python/steering-council#214

@gvanrossum
Copy link
Member

I propose "multicore".

@hugovk
Copy link
Member Author

hugovk commented Nov 20, 2023

hugovk added a commit that referenced this issue Nov 20, 2023
Rename Py_NOGIL to Py_GIL_DISABLED
@hugovk hugovk closed this as completed Nov 20, 2023
Yhg1s added a commit that referenced this issue Nov 21, 2023
…dent. (#112300)

Rename blurb snippet placed in the wrong directory by accident.
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
…y accident. (python#112300)

Rename blurb snippet placed in the wrong directory by accident.
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
…y accident. (python#112300)

Rename blurb snippet placed in the wrong directory by accident.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes topic-free-threading
Projects
None yet
Development

No branches or pull requests

5 participants