-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unicode: make ucnhash_capi initialization thread-safe in --disable-gil
builds
#111972
Closed
Tracked by
#108219
Labels
Comments
colesbury
added
type-feature
A feature request or enhancement
3.13
bugs and security fixes
topic-free-threading
labels
Nov 10, 2023
Eclips4
added a commit
to Eclips4/cpython
that referenced
this issue
Nov 18, 2023
This seems quite easy 😄 |
erlend-aasland
pushed a commit
that referenced
this issue
Nov 30, 2023
Resolved by #112249 |
aisk
pushed a commit
to aisk/cpython
that referenced
this issue
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this issue
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature or enhancement
The
_PyUnicode_Name_CAPI
provides functions to get the name for a given Unicode character code and vice versa. It is lazily initialized and stored in the per-interpreter_Py_unicode_state
:cpython/Include/internal/pycore_unicodeobject.h
Lines 425 to 432 in 3932b0f
The initialization of the
ucnhash_capi
isn't thread-safe without the GIL. (There can be a data race on reading and writingucnhash_capi
).Mostly for my own reference, here are the similar modifications in the
nogil-3.12
fork: colesbury/nogil-3.12@5d006db9faLinked PRs
ucnhash_capi
capsule initialization thread-safe #112249The text was updated successfully, but these errors were encountered: