Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_builtins_have_signatures in test_inspect #112001

Closed
serhiy-storchaka opened this issue Nov 12, 2023 · 0 comments
Closed

Fix test_builtins_have_signatures in test_inspect #112001

serhiy-storchaka opened this issue Nov 12, 2023 · 0 comments
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Nov 12, 2023 •
edited by bedevere-app bot
Loading

test_builtins_have_signatures in test_inspect is only passed by accident. It always passed because it checked the same object (the last object the builtins module, zip) in the loop that had no signature. But after adding the signature for zip in #111999 it exploded with failures.

Linked PRs
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir 3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes labels Nov 12, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 12, 2023
@serhiy-storchaka
pythongh-112001: Fix test_builtins_have_signatures in test_inspect
6268938
@bedevere-app bedevere-app bot mentioned this issue Nov 12, 2023
Merged
@serhiy-storchaka serhiy-storchaka mentioned this issue Nov 12, 2023
Closed
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 12, 2023
@serhiy-storchaka
pythongh-112001: Fix test_builtins_have_signatures in test_inspect
c3cec6a
serhiy-storchaka added a commit that referenced this issue Nov 12, 2023
@serhiy-storchaka
gh-112001: Fix test_builtins_have_signatures in test_inspect (GH-112002)
40752c1
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 12, 2023
@serhiy-storchaka @miss-islington
pythongh-112001: Fix test_builtins_have_signatures in test_inspect (p…
b744563 
…ythonGH-112002)

(cherry picked from commit 40752c1)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Nov 12, 2023
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 12, 2023
@serhiy-storchaka @miss-islington
pythongh-112001: Fix test_builtins_have_signatures in test_inspect (p…
cb6bee5 
…ythonGH-112002)

(cherry picked from commit 40752c1)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue Nov 12, 2023
Merged
serhiy-storchaka added a commit that referenced this issue Nov 12, 2023
@miss-islington @serhiy-storchaka
[3.11] gh-112001: Fix test_builtins_have_signatures in test_inspect (G…
9536fe1 
…H-112002) (GH-112004)

(cherry picked from commit 40752c1)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this issue Nov 12, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-112001: Fix test_builtins_have_signatures in test_inspect (G…
378a96e 
…H-112002) (GH-112003)

(cherry picked from commit 40752c1)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-112001: Fix test_builtins_have_signatures in test_inspect (p…
9b8ad47 
…ythonGH-112002)
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-112001: Fix test_builtins_have_signatures in test_inspect (p…
320777d 
…ythonGH-112002)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 bugs and security fixes tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@serhiy-storchaka