Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make random.Random thread-safe in --disable-gil builds #112071

Closed
Tracked by #108219
colesbury opened this issue Nov 14, 2023 · 1 comment · Fixed by #112128
Closed
Tracked by #108219

Make random.Random thread-safe in --disable-gil builds #112071

colesbury opened this issue Nov 14, 2023 · 1 comment · Fixed by #112128
Assignees
@chgnrdv
Labels
3.13 bugs and security fixes extension-modules C modules in the Modules dir topic-free-threading type-feature A feature request or enhancement

Comments

@colesbury
Copy link
Contributor

colesbury commented Nov 14, 2023 •
edited
Loading

Feature or enhancement

random.Random has mutable internal state. We should use the critical section API to make it thread-safe in --disable-gil builds.

For context, here is the change from the nogil-3.12 fork. colesbury/nogil-3.12@9bf62ffc4b. Note that we want to do things a bit differently in CPython 3.13:

  1. No need for an extra _PyMutex mutex in RandomObject
  2. Use the critical section API. Locking can be added around operations that use Argument Clinic by adding the @critical_section directive as the first line.
  3. Compared to nogil-3.12, we want to push the locking "up" to the around the methods. (See the above note 2).

Linked PRs
@colesbury colesbury added type-feature A feature request or enhancement 3.13 bugs and security fixes topic-free-threading labels Nov 14, 2023
@colesbury colesbury mentioned this issue Nov 14, 2023
Open
@AlexWaygood AlexWaygood added the extension-modules C modules in the Modules dir label Nov 14, 2023
chgnrdv added a commit to chgnrdv/cpython that referenced this issue Nov 15, 2023
@chgnrdv
pythongh-112071: Make _random.Random methods thread-safe in `--disa…
54180e1 
…ble-gil` builds

Guard `_random.Random` methods with critical section API locks by using `@critical_section` AC directive
@chgnrdv chgnrdv mentioned this issue Nov 15, 2023
Merged
@chgnrdv
Copy link
Contributor

chgnrdv commented Nov 15, 2023

The PR is done.

@colesbury colesbury assigned colesbury and chgnrdv and unassigned colesbury Nov 15, 2023
corona10 added a commit that referenced this issue Nov 28, 2023
@chgnrdv @corona10
gh-112071: Make _random.Random methods thread-safe in `--disable-gi…
ac4b442 
…l` builds (gh-112128)


Co-authored-by: Donghee Na <donghee.na@python.org>
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@chgnrdv @corona10 @aisk
pythongh-112071: Make _random.Random methods thread-safe in `--disa…
8e17880 
…ble-gil` builds (pythongh-112128)


Co-authored-by: Donghee Na <donghee.na@python.org>
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@chgnrdv @corona10 @Glyphack
pythongh-112071: Make _random.Random methods thread-safe in `--disa…
9a4e278 
…ble-gil` builds (pythongh-112128)


Co-authored-by: Donghee Na <donghee.na@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chgnrdv chgnrdv

Labels
3.13 bugs and security fixes extension-modules C modules in the Modules dir topic-free-threading type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-112071: Make _random.Random methods thread-safe in --disable-gil builds chgnrdv/cpython
3 participants
@colesbury @chgnrdv @AlexWaygood