Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash of interpreter due to unclosed sub-interpreters #113433

Closed
Eclips4 opened this issue Dec 23, 2023 · 3 comments
Closed

Crash of interpreter due to unclosed sub-interpreters #113433

Eclips4 opened this issue Dec 23, 2023 · 3 comments
Labels
topic-subinterpreters type-crash A hard crash of the interpreter, possibly with a core dump

Comments

@Eclips4
Copy link
Member

Eclips4 commented Dec 23, 2023 •
edited by bedevere-app bot
Loading

Crash report

Reproducer:

import _xxsubinterpreters as interp

interp_id = interp.create()

Trace:

Fatal Python error: PyInterpreterState_Delete: remaining subinterpreters
Python runtime state: finalizing (tstate=0x00005576a7f343e0)

Aborted

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@Eclips4 Eclips4 added type-crash A hard crash of the interpreter, possibly with a core dump topic-subinterpreters labels Dec 23, 2023
@Eclips4
Copy link
Member Author

Eclips4 commented Dec 23, 2023

Bisected to 86a77f4
cc @ericsnowcurrently

@ericsnowcurrently
Copy link
Member

Sorry for the delay. I'll try to take a look in the next day or two.

@Eclips4 Eclips4 mentioned this issue Jun 20, 2024
Closed
@bedevere-app bedevere-app bot mentioned this issue Jun 26, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 26, 2024
@ericsnowcurrently @miss-islington
pythongh-113433: Automatically Clean Up Subinterpreters in Py_Finaliz…
8c13544 
…e() (pythongh-121060)

This change makes things a little less painful for some users.  It also fixes a failing assert (pythongh-120765), by making sure all subinterpreters are destroyed before the main interpreter.  As part of that, we make sure Py_Finalize() always runs with the main interpreter active.
(cherry picked from commit 4be1f37)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
ericsnowcurrently added a commit that referenced this issue Jun 26, 2024
@ericsnowcurrently
gh-113433: Automatically Clean Up Subinterpreters in Py_Finalize() (g…
4be1f37 
…h-121060)

This change makes things a little less painful for some users.  It also fixes a failing assert (gh-120765), by making sure all subinterpreters are destroyed before the main interpreter.  As part of that, we make sure Py_Finalize() always runs with the main interpreter active.
@bedevere-app bedevere-app bot mentioned this issue Jun 26, 2024
Merged
ericsnowcurrently added a commit that referenced this issue Jun 26, 2024
@miss-islington @ericsnowcurrently
[3.13] gh-113433: Automatically Clean Up Subinterpreters in Py_Finali…
c839974 
…ze() (gh-121067)

This change makes things a little less painful for some users.  It also fixes a failing assert (gh-120765), by making sure all subinterpreters are destroyed before the main interpreter.  As part of that, we make sure Py_Finalize() always runs with the main interpreter active.

(cherry picked from commit 4be1f37, AKA gh-121060)

Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@ericsnowcurrently
Copy link
Member

This should be all sorted for main and 3.13. Backporting to 3.12 isn't really an option.

@github-project-automation github-project-automation bot moved this from Todo to Done in Subinterpreters Jun 26, 2024
mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
@ericsnowcurrently @mrahtz
pythongh-113433: Automatically Clean Up Subinterpreters in Py_Finaliz…
7aa0f5d 
…e() (pythongh-121060)

This change makes things a little less painful for some users.  It also fixes a failing assert (pythongh-120765), by making sure all subinterpreters are destroyed before the main interpreter.  As part of that, we make sure Py_Finalize() always runs with the main interpreter active.
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@ericsnowcurrently @noahbkim
pythongh-113433: Automatically Clean Up Subinterpreters in Py_Finaliz…
04ea2e9 
…e() (pythongh-121060)

This change makes things a little less painful for some users.  It also fixes a failing assert (pythongh-120765), by making sure all subinterpreters are destroyed before the main interpreter.  As part of that, we make sure Py_Finalize() always runs with the main interpreter active.
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@ericsnowcurrently @estyxx
pythongh-113433: Automatically Clean Up Subinterpreters in Py_Finaliz…
1a151b0 
…e() (pythongh-121060)

This change makes things a little less painful for some users.  It also fixes a failing assert (pythongh-120765), by making sure all subinterpreters are destroyed before the main interpreter.  As part of that, we make sure Py_Finalize() always runs with the main interpreter active.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic-subinterpreters type-crash A hard crash of the interpreter, possibly with a core dump
Projects
Subinterpreters
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ericsnowcurrently @Eclips4