Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tier 2 optimizations for 3.13 #115419

Closed
21 of 32 tasks
Tracked by #113710
markshannon opened this issue Feb 13, 2024 · 3 comments
Closed
21 of 32 tasks
Tracked by #113710

Tier 2 optimizations for 3.13 #115419

markshannon opened this issue Feb 13, 2024 · 3 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage type-feature A feature request or enhancement

Comments

@markshannon
Copy link
Member

markshannon commented Feb 13, 2024

Feature or enhancement

Prerequisites

Optimizations to be added to the tier 2 optimizer for 3.13

If we have time:

Linked PRs

@markshannon markshannon added type-feature A feature request or enhancement performance Performance or resource usage labels Feb 13, 2024
@mdboom
Copy link
Contributor

mdboom commented Feb 13, 2024

This is perhaps so rough as to be meaningless (i.e. uop counts != run time), but in an attempt to help prioritize these tasks, I thought I'd share some aggregate counts from a recent pyperformance run:

Grouping Uops included in group Total
TO_BOOL TO_BOOL_ALWAYS_TRUE, TO_BOOL_BOOL, TO_BOOL_INT, TO_BOOL_LIST, TO_BOOL_NONE, TO_BOOL_STR, _TO_BOOL 1,296,284,467
LOAD_ATTR_MODULE 96,542,580
BINARY_OP _BINARY_OP_MULTIPLY_INT, _BINARY_OP_ADD_INT, _BINARY_OP_SUBTRACT_INT, _BINARY_OP_ADD_UNICODE, _BINARY_OP, _BINARY_OP_MULTIPLY_FLOAT, _BINARY_OP_ADD_FLOAT, _BINARY_OP_SUBTRACT_FLOAT 5,308,844,150
COMPARE_OP COMPARE_OP_INT, COMPARE_OP_STR, _COMPARE_OP, COMPARE_OP_FLOAT 2,404,431,292
CONTAINS_OP 1,654,609,694

@markshannon: Let me know if anything else like this would be helpful.

@Eclips4 Eclips4 added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Feb 14, 2024
@Fidget-Spinner
Copy link
Member

I am assigning myself all binary op related stuff. Since it is relatively straightforward.

vstinner pushed a commit to vstinner/cpython that referenced this issue Mar 20, 2024
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@markshannon
Copy link
Member Author

3.13 is nearing release, so nothing more is going in 3.13.

Everything we didn't get done for 3.13 will get into 3.14 (if it hasn't been done already)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

4 participants