Skip to content

Exercise the debug structs placed in PyRuntime #115773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pablogsal opened this issue Feb 21, 2024 · 3 comments
Closed

Exercise the debug structs placed in PyRuntime #115773

pablogsal opened this issue Feb 21, 2024 · 3 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) tests Tests in the Lib/test dir

Comments

@pablogsal
Copy link
Member

pablogsal commented Feb 21, 2024

To avoid breaking external inspection, profilers and debuggers too often or to make supporting them too difficult, we added a special offset struct in the PyRuntime structure. Unfortunately there is nothing testing that this offsets are correct or that they are enough to analyse or profile a Python application on their own. To fix this, we should add some testing that exercises the offsets and ensure they are enough to serve the purpose they were added.

Linked PRs

@erlend-aasland erlend-aasland added tests Tests in the Lib/test dir interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Feb 21, 2024
pablogsal pushed a commit that referenced this issue Mar 1, 2024
…116212)

Add missing preprocessor guard in _testexternalinspection
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this issue Mar 4, 2024
…ction (python#116212)

Add missing preprocessor guard in _testexternalinspection
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
…ction (python#116212)

Add missing preprocessor guard in _testexternalinspection
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
…ction (python#116212)

Add missing preprocessor guard in _testexternalinspection
pablogsal added a commit to pablogsal/cpython that referenced this issue Jun 5, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 2, 2024
(cherry picked from commit b180788)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this issue Jul 2, 2024
…21283)

gh-115773: Add sizes to debug offset structure (GH-120112)
(cherry picked from commit b180788)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@encukou
Copy link
Member

encukou commented Jan 30, 2025

@pablogsal, you probably have the most context here. Could you check #125402 and #129430?

@pablogsal
Copy link
Member Author

I will try to take a look today

@encukou
Copy link
Member

encukou commented Jan 31, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) tests Tests in the Lib/test dir
Projects
None yet
Development

No branches or pull requests

3 participants