Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PathFinder.invalidate_caches should include MetadataPathFinder.invalidate_caches #116811

Closed
jaraco opened this issue Mar 14, 2024 · 2 comments
Closed

PathFinder.invalidate_caches should include MetadataPathFinder.invalidate_caches #116811

jaraco opened this issue Mar 14, 2024 · 2 comments

Comments

@jaraco
Copy link
Member

jaraco commented Mar 14, 2024 •
edited by bedevere-app bot
Loading

MetadataPathFinder.invalidate_caches should be called from PathFinder.invalidate_caches, as that will match the behavior that would happen if MetadataPathFinder were on sys.meta_path.

Originally posted by @jaraco in #116763 (comment)

Linked PRs
@jaraco
Copy link
Member Author

jaraco commented Mar 14, 2024

PathFinder already delegates its find_distributions to MetadataPathFinder, so it's probably best to delegate this function as well.

@bedevere-app bedevere-app bot mentioned this issue Mar 14, 2024
Merged
jaraco added a commit that referenced this issue Mar 14, 2024
@jaraco
gh-116811: Ensure MetadataPathFinder.invalidate_caches is reachable w…
5f52d20 
…hen delegated through PathFinder. (#116812)

* Make MetadataPathFinder a proper classmethod.

* In PathFinder.invalidate_caches, also invoke MetadataPathFinder.invalidate_caches.

* Add blurb
jaraco added a commit to jaraco/cpython that referenced this issue Mar 15, 2024
@jaraco
[3.12] pythongh-116811: Ensure MetadataPathFinder.invalidate_caches i…
4a84594 
…s reachable when delegated through PathFinder. (pythonGH-116812)

* Make MetadataPathFinder a proper classmethod.

* In PathFinder.invalidate_caches, also invoke MetadataPathFinder.invalidate_caches.

* Add blurb
(cherry picked from commit 5f52d20)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-app bedevere-app bot mentioned this issue Mar 15, 2024
Merged
jaraco added a commit to jaraco/cpython that referenced this issue Mar 15, 2024
@jaraco
[3.11] pythongh-116811: Ensure MetadataPathFinder.invalidate_caches i…
cc31cbd 
…s reachable when delegated through PathFinder. (pythonGH-116812)

* Make MetadataPathFinder a proper classmethod.

* In PathFinder.invalidate_caches, also invoke MetadataPathFinder.invalidate_caches.

* Add blurb
(cherry picked from commit 5f52d20)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@bedevere-app bedevere-app bot mentioned this issue Mar 15, 2024
Merged
jaraco added a commit that referenced this issue Mar 15, 2024
@jaraco
[3.12] gh-116811: Ensure MetadataPathFinder.invalidate_caches is reac…
8336cb2 
…hable when delegated through PathFinder. (GH-116812) (#116864)

* Make MetadataPathFinder a proper classmethod.

* In PathFinder.invalidate_caches, also invoke MetadataPathFinder.invalidate_caches.

* Add blurb
(cherry picked from commit 5f52d20)
jaraco added a commit that referenced this issue Mar 15, 2024
@jaraco
[3.11] gh-116811: Ensure MetadataPathFinder.invalidate_caches is reac…
8acd6ca 
…hable when delegated through PathFinder. (GH-116812) (#116865)

* Make MetadataPathFinder a proper classmethod.

* In PathFinder.invalidate_caches, also invoke MetadataPathFinder.invalidate_caches.

* Add blurb
(cherry picked from commit 5f52d20)
@hugovk
Copy link
Member

hugovk commented Mar 15, 2024

Closing as the PRs have been merged and backported. Please let us know if there's still more to do. Thanks!

@hugovk hugovk closed this as completed Mar 15, 2024
vstinner pushed a commit to vstinner/cpython that referenced this issue Mar 20, 2024
@jaraco @vstinner
pythongh-116811: Ensure MetadataPathFinder.invalidate_caches is reach…
96a8f09 
…able when delegated through PathFinder. (python#116812)

* Make MetadataPathFinder a proper classmethod.

* In PathFinder.invalidate_caches, also invoke MetadataPathFinder.invalidate_caches.

* Add blurb
adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
@jaraco @adorilson
pythongh-116811: Ensure MetadataPathFinder.invalidate_caches is reach…
17a959f 
…able when delegated through PathFinder. (python#116812)

* Make MetadataPathFinder a proper classmethod.

* In PathFinder.invalidate_caches, also invoke MetadataPathFinder.invalidate_caches.

* Add blurb
diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
@jaraco @diegorusso
pythongh-116811: Ensure MetadataPathFinder.invalidate_caches is reach…
68fc9be 
…able when delegated through PathFinder. (python#116812)

* Make MetadataPathFinder a proper classmethod.

* In PathFinder.invalidate_caches, also invoke MetadataPathFinder.invalidate_caches.

* Add blurb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaraco @hugovk