Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change JUMP_TO_TOP to a more general backwards jump for tier 2. #117062

Closed
markshannon opened this issue Mar 20, 2024 · 0 comments
Closed

Change JUMP_TO_TOP to a more general backwards jump for tier 2. #117062

markshannon opened this issue Mar 20, 2024 · 0 comments
Labels
3.13 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage

Comments

@markshannon
Copy link
Member

markshannon commented Mar 20, 2024 •
edited by bedevere-app bot
Loading

Currently we have the _JUMP_TO_TOP uop which jumps to the second uop in the tier 2 trace, as the first is reserved for _START_EXECUTOR.
Since this is a bit of an odd special case, we might as well add a more general jump backward.
Doing so would have a few advantages:

  • It is less confusing
  • It would actually simplify the JIT a bit
  • It would allow loop invariant code motion for looping traces.

Linked PRs
@markshannon markshannon added type-feature A feature request or enhancement performance Performance or resource usage 3.13 bugs and security fixes labels Mar 20, 2024
@markshannon markshannon mentioned this issue Mar 20, 2024
Merged
@gvanrossum gvanrossum added interpreter-core (Objects, Python, Grammar, and Parser dirs) and removed type-feature A feature request or enhancement labels Mar 20, 2024
@gvanrossum gvanrossum mentioned this issue Mar 20, 2024
Open
@bedevere-app bedevere-app bot mentioned this issue Jun 21, 2024
Merged
brandtbucher added a commit that referenced this issue Jun 24, 2024
@brandtbucher
GH-117062: Make _JUMP_TO_TOP a general absolute jump (GH-120854)
a47abdb
mrahtz pushed a commit to mrahtz/cpython that referenced this issue Jun 30, 2024
@brandtbucher @mrahtz
pythonGH-117062: Make _JUMP_TO_TOP a general absolute jump (pythonGH-…
e8e94c2 
…120854)
noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@brandtbucher @noahbkim
pythonGH-117062: Make _JUMP_TO_TOP a general absolute jump (pythonGH-…
b562d88 
…120854)
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@brandtbucher @estyxx
pythonGH-117062: Make _JUMP_TO_TOP a general absolute jump (pythonGH-…
684f2da 
…120854)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gvanrossum @markshannon @brandtbucher