Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip individual tests (not entire files) when running emulated JIT CI #118251

Closed
brandtbucher opened this issue Apr 24, 2024 · 1 comment
Closed

Skip individual tests (not entire files) when running emulated JIT CI #118251

brandtbucher opened this issue Apr 24, 2024 · 1 comment
Assignees
@savannahostrowski
Labels
tests Tests in the Lib/test dir topic-JIT

Comments

@brandtbucher
Copy link
Member

brandtbucher commented Apr 24, 2024 •
edited by bedevere-app bot
Loading

Since we don't have AArch64 runners, four JIT CI jobs are run under emulation.

Unfortunately, our test suite wasn't exactly designed to be run using qemu-user. That's okay, but it means that these jobs currently --exclude a bunch of test files for low-level OS functionality that currently either crash, fail, or hang under emulation.

Rather than excluding the entire files, we should probably maintain a text file of individual tests and use our test runner's --ignorefile option instead. That way, we would still have pretty good coverage of these modules.

Anyone interested in doing this?

Linked PRs
@brandtbucher brandtbucher added the tests Tests in the Lib/test dir label Apr 24, 2024
@brandtbucher brandtbucher mentioned this issue Apr 24, 2024
Closed
@savannahostrowski
Copy link
Member

I'm going to take a look into this!

@bedevere-app bedevere-app bot mentioned this issue May 3, 2024
Merged
brandtbucher pushed a commit that referenced this issue May 3, 2024
@savannahostrowski
GH-118251: Skip fewer test in emulated JIT CI (GH-118536)
5248596
@bedevere-app bedevere-app bot mentioned this issue May 3, 2024
Merged
brandtbucher added a commit that referenced this issue May 3, 2024
@brandtbucher
GH-118251: Fix incomplete ternary expression in JIT workflow (GH-118564)
139dc48
@bedevere-app bedevere-app bot mentioned this issue May 6, 2024
Merged
ambv pushed a commit that referenced this issue May 6, 2024
@brandtbucher
GH-118251: Bump the JIT CI timeout to 90 minutes (#118661)
430945d
SonicField pushed a commit to SonicField/cpython that referenced this issue May 8, 2024
@savannahostrowski @SonicField
pythonGH-118251: Skip fewer test in emulated JIT CI (pythonGH-118536)
4670d66
SonicField pushed a commit to SonicField/cpython that referenced this issue May 8, 2024
@brandtbucher @SonicField
pythonGH-118251: Fix incomplete ternary expression in JIT workflow (p…
41ddb01 
…ythonGH-118564)
SonicField pushed a commit to SonicField/cpython that referenced this issue May 8, 2024
@brandtbucher @SonicField
pythonGH-118251: Bump the JIT CI timeout to 90 minutes (python#118661)
c82083b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@savannahostrowski savannahostrowski

Labels
tests Tests in the Lib/test dir topic-JIT
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@savannahostrowski @brandtbucher