-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freethreading build fails -m test --pgo: test_ordered_dict and test_struct failed #118846
Labels
Comments
All of thew failures seem to be related to reference loops/cycles. |
I think this is related to the immortalization of objects in the free-threaded build: #117783 |
Runnin all the tests sequentially, I see even more failures.
They succeed when run with |
colesbury
added a commit
to colesbury/cpython
that referenced
this issue
May 9, 2024
Avoid immortalizing objects in some tests that test behavior of collecting classes or modules. This fixes test_ordered_dict and test_struct.
colesbury
added a commit
to colesbury/cpython
that referenced
this issue
May 9, 2024
Avoid immortalizing objects in some tests that test behavior of collecting classes or modules. This fixes test_ordered_dict and test_struct.
colesbury
added a commit
to colesbury/cpython
that referenced
this issue
May 9, 2024
The free-threaded build currently immortalizes some objects once the first thread is started. This can lead to test failures depending on the order in which tests are run. This PR addresses those failures by suppressing immortalization or skipping the affected tests.
colesbury
added a commit
that referenced
this issue
May 9, 2024
Avoid immortalizing objects in tests that verify garbage collection of classes or modules. This fixes test_ordered_dict and test_struct.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
May 9, 2024
Avoid immortalizing objects in tests that verify garbage collection of classes or modules. This fixes test_ordered_dict and test_struct. (cherry picked from commit 1b1db2f) Co-authored-by: Sam Gross <colesbury@gmail.com>
SonicField
pushed a commit
to SonicField/cpython
that referenced
this issue
May 10, 2024
Avoid immortalizing objects in tests that verify garbage collection of classes or modules. This fixes test_ordered_dict and test_struct.
hroncok
pushed a commit
to fedora-python/cpython
that referenced
this issue
May 10, 2024
Avoid immortalizing objects in tests that verify garbage collection of classes or modules. This fixes test_ordered_dict and test_struct. (cherry picked from commit 1b1db2f)
colesbury
added a commit
to colesbury/cpython
that referenced
this issue
May 10, 2024
I was at least able to install it when using |
colesbury
added a commit
that referenced
this issue
May 10, 2024
…18864) The free-threaded build currently immortalizes some objects once the first thread is started. This can lead to test failures depending on the order in which tests are run. This PR addresses those failures by suppressing immortalization or skipping the affected tests.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
May 10, 2024
…ly (pythonGH-118864) The free-threaded build currently immortalizes some objects once the first thread is started. This can lead to test failures depending on the order in which tests are run. This PR addresses those failures by suppressing immortalization or skipping the affected tests. (cherry picked from commit b309c8e) Co-authored-by: Sam Gross <colesbury@gmail.com>
colesbury
added a commit
that referenced
this issue
May 10, 2024
…lly (GH-118864) (#118927) The free-threaded build currently immortalizes some objects once the first thread is started. This can lead to test failures depending on the order in which tests are run. This PR addresses those failures by suppressing immortalization or skipping the affected tests. (cherry picked from commit b309c8e) Co-authored-by: Sam Gross <colesbury@gmail.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this issue
Jul 17, 2024
…ly (python#118864) The free-threaded build currently immortalizes some objects once the first thread is started. This can lead to test failures depending on the order in which tests are run. This PR addresses those failures by suppressing immortalization or skipping the affected tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug report
Bug description:
When we build Python 3.13.0b1 in Fedora with
--disable-gil --enable-optimizations
, the PGO task fails. I was able to reproduce this from the 3.13 branch by:Interestingly, the tests pass when run individually:
But not when all of them run:
I don't know what the failure is, as using
-v
is not possible:I can however run the pgo tests manually like this:
CPython versions tested on:
3.13
Operating systems tested on:
Linux
Linked PRs
The text was updated successfully, but these errors were encountered: