-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer import warnings
in pathlib
#119049
Labels
Comments
I've written #119063 to address this. FYI, this is not related to |
serhiy-storchaka
pushed a commit
that referenced
this issue
May 16, 2024
… API (GH-119063) The source line was not displayed if the warnings module had not yet been imported.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
May 16, 2024
…d by C API (pythonGH-119063) The source line was not displayed if the warnings module had not yet been imported. (cherry picked from commit 100c7ab) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Eclips4
added a commit
to Eclips4/cpython
that referenced
this issue
May 17, 2024
This was referenced May 17, 2024
serhiy-storchaka
pushed a commit
that referenced
this issue
May 17, 2024
barneygale
pushed a commit
that referenced
this issue
May 17, 2024
Woot! Thank you @Eclips4 for sorting this :) |
estyxx
pushed a commit
to estyxx/cpython
that referenced
this issue
Jul 17, 2024
…d by C API (pythonGH-119063) The source line was not displayed if the warnings module had not yet been imported.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this issue
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of GH-118793, the
warnings
module is used only once in pathlib, byPurePath.is_reserved()
. We should be able to move theimport warnings
line into that method. But beware! Doing so seems to cause a failure intest_io
, which needs further investigation.Linked PRs
GET_WARNINGS_ATTR
#119063import warnings
inpathlib._locals
#119111The text was updated successfully, but these errors were encountered: