Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipython breaks on Python-3.13.0b1 when a 'tempfilepager' is not defined #119185

Closed
stonebig opened this issue May 19, 2024 · 4 comments
Closed

ipython breaks on Python-3.13.0b1 when a 'tempfilepager' is not defined #119185

stonebig opened this issue May 19, 2024 · 4 comments
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes easy triaged The issue has been accepted as valid by a triager. type-bug An unexpected behavior, bug, or error

Comments

@stonebig
Copy link

stonebig commented May 19, 2024

Bug report

Bug description:

on a windows Python-3.13.0b1 non-english

test:

Python 3.13.0b1 (tags/v3.13.0b1:2268289, May  8 2024, 12:20:07) [MSC v.1938 64 bit (AMD64)]
Type 'copyright', 'credits' or 'license' for more information
IPython 8.24.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: help(len)

result:

Unexpected exception formatting exception. Falling back to standard exception
Traceback (most recent call last):
  File "......\python-3.13.0b1.amd64\Lib\site-packages\IPython\core\interactiveshell.py", line 3577, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
    ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<ipython-input-1-1dda769017ba>", line 1, in <module>
    help(len)
    ~~~~^^^^^
  File "<frozen _sitebuiltins>", line 103, in __call__
  File "......\python-3.13.0b1.amd64\Lib\pydoc.py", line 1983, in __call__
    self.help(request)
    ~~~~~~~~~^^^^^^^^^
  File "......\python-3.13.0b1.amd64\Lib\pydoc.py", line 2044, in help
    else: doc(request, 'Help on %s:', output=self._output, is_cli=is_cli)
          ~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "......\python-3.13.0b1.amd64\Lib\pydoc.py", line 1757, in doc
    pager(render_doc(thing, title, forceload), f'Help on {what!s}')
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "......\python-3.13.0b1.amd64\Lib\pydoc.py", line 1656, in pager
    pager(text, title)
    ~~~~~^^^^^^^^^^^^^
  File "......\python-3.13.0b1.amd64\Lib\_pyrepl\pager.py", line 38, in <lambda>
    return lambda text, title='': tempfilepager(plain(text), 'more <')
                                  ^^^^^^^^^^^^^
NameError: name 'tempfilepager' is not defined. Did you mean: 'tempfile_pager'?

CPython versions tested on:

3.13

Operating systems tested on:

Windows

Linked PRs

@stonebig stonebig added the type-bug An unexpected behavior, bug, or error label May 19, 2024
@stonebig
Copy link
Author

stonebig commented May 19, 2024

the fingerprint says:
image

version of packages used:

          ipython==8.24.0 ,
               decorator==5.1.1
               jedi==0.19.1 >=0.16,
                    parso==0.8.4 (<0.9.0,>=0.8.3)
               matplotlib-inline==0.1.6 ,
                    traitlets==5.14.1
               prompt-toolkit==3.0.43 <3.1.0,>=3.0.41,
                    wcwidth==0.2.13
               pygments==2.17.2 >=2.4.0
               stack-data==0.6.3 ,
                    executing==2.0.1 >=1.2.0
                    asttokens==2.4.1 >=2.1.0,
                         six==1.16.0 >=1.12.0
                    pure-eval==0.2.2
               traitlets==5.14.1 >=5.13.0
               colorama==0.4.6

@graingert
Copy link
Contributor

This is a typo it should be tempfile_pager

@graingert graingert added triaged The issue has been accepted as valid by a triager. 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels May 19, 2024
@graingert graingert added the easy label May 19, 2024
@terryjreedy terryjreedy changed the title ipython breaks on Python-3.13.0b1 with a 'tempfilepager' is not defined ipython breaks on Python-3.13.0b1 when a 'tempfilepager' is not defined May 19, 2024
@Eclips4
Copy link
Member

Eclips4 commented May 19, 2024

We have already a PR for fix that: #118881

JelleZijlstra pushed a commit that referenced this issue May 20, 2024
…mpfile_pager` (#118881)

Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`

The name with no underscore doesn't exist.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 20, 2024
…be `tempfile_pager` (pythonGH-118881)

Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`

The name with no underscore doesn't exist.
(cherry picked from commit 05e1dce)

Co-authored-by: Thanos <111999343+Sachaa-Thanasius@users.noreply.github.com>
JelleZijlstra pushed a commit that referenced this issue May 20, 2024
… be `tempfile_pager` (GH-118881) (#119211)

Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`

The name with no underscore doesn't exist.
(cherry picked from commit 05e1dce)

Co-authored-by: Thanos <111999343+Sachaa-Thanasius@users.noreply.github.com>
@vstinner
Copy link
Member

Fixed by 05e1dce

estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
…be `tempfile_pager` (python#118881)

Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`

The name with no underscore doesn't exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes easy triaged The issue has been accepted as valid by a triager. type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

4 participants