[Windows]: HiDPI causes every program window that using tkinter blurry

[Wulian233]

Bug report

Bug description:

Operating systems tested on:

Windows

Linked PRs

• CLOSE: Fix high DPI causes Tools/unittestgui(PyUnit) window blurry on Windows #119460
• gh-119459: Fix HiDPI blurring of every program window that using tkinter #119902

[terryjreedy]

@serhiy-storchaka Since this HiDPI issue is a tk/tkinter issue, it seems to me that the fix should be in, or available from tkinter, at least, instead of only in idlelib. What you you think? (See current PR #11940.) I believe the fix was given to me by @zooba.

[serhiy-storchaka]

What can be a disadvantage of always enabling this?

We can add the corresponding option in the manifest of the Python build on Windows. This will solve problem for IDLE, turtledemo, unittestgui and all other Python programs that are launched via the Python executable. But not for built-in Python interpreter. And it will affect other Python GUIs, that can a plus or a minus.

Or we can add the corresponding call when the Tk root widget is created.

[Wulian233]

I closed #119460 PR and I'm will to fix it in the __init.py__ in tkinter, so that all programs that use tkinter can be fixed without any code changes

[TeamSpen210]

There might need to be some sort of migration required for this. I tried enabling it on my own application, but it does result in uneven dimension changes for different widgets. In particular UI created with place(), using sized images and the like could become incorrect.

[maj113]

It does seem to have a negative effect on icons placed in the treeview widget, left side padding needs to be adjusted
(right window is the one with the fix from #119902
in my case I had to adjust the padding from -21 to -25 to get it to look the same as it did before

[Wulian233]

The size changing is a known issue, and I fixed the bug before ba34aa5, but it caused the test to fail.

And then, I removed it, so now the test passes, but the size may change

[Wulian233]

@TeamSpen210 @maj113 I have fixed the problem that it caused the size anomaly, and the test has passed. Does it work for you? ☺️

[maj113]

Yes, it does, seems like images are not scaled, I'm not sure if this is intentional?

Seems like padding needs to be adjusted again on my end after the newest commit

with newest commit:

without the PR:

I personally prefer the previous DPI aware version without scaling, tkinter doesn't scale everything properly and it would lead to inconsistencies when ran on different systems

[Wulian233]

It looks good. In my latest commit, I used ScaleFactor/75 to keep the window size constant. 75 is a well-tested number used by many people https://github.com/search?q=ScaleFactor/75&type=code&p=3

But now there may be a little bit of a problem, if apply this patch to a 100% resolution screen, what will happen? Like your?
So maybe we can only apply it on high dpi screens, which should be the best way☺️

https://github.com/tongfeima/Make_Anki_Package/blob/refs/heads/main/GUI.py#L11-L15

[maj113]

It looks good.

Yeah but again some elements are not scaled (frames, images) it may lead to inconsistencies;

OS scaling set to 150%:

OS scaling set to 100%

But now there may be a little bit of a problem, if apply this patch to a 100% resolution screen, what will happen?

100
Previous scaling factor: 1.3339898243886428
Current scaling factor: 1.3339898243886428

No change, tested with this:

                ScaleFactor = ctypes.windll.shcore.GetScaleFactorForDevice(0)
                print(ScaleFactor)
                scaling = self.tk.call('tk', 'scaling')

                print(f"Previous scaling factor: {scaling}")
                self.tk.call('tk', 'scaling', ScaleFactor / 75)
                scaling = self.tk.call('tk', 'scaling')

                print(f"Current scaling factor: {scaling}")