-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve deprecation warning message, when a test case returns non None
value
#120388
Labels
Comments
sobolevn
added
type-feature
A feature request or enhancement
tests
Tests in the Lib/test dir
labels
Jun 12, 2024
sobolevn
added a commit
to sobolevn/cpython
that referenced
this issue
Jun 12, 2024
sobolevn
added a commit
to sobolevn/cpython
that referenced
this issue
Jun 12, 2024
sobolevn
added a commit
to sobolevn/cpython
that referenced
this issue
Jun 12, 2024
sobolevn
added a commit
that referenced
this issue
Jun 12, 2024
…-None (#120401) Co-authored-by: Alex Waygood <alex.waygood@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Thanks for doing this @sobolevn! :D |
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this issue
Jun 30, 2024
…ns non-None (python#120401) Co-authored-by: Alex Waygood <alex.waygood@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this issue
Jul 11, 2024
…ns non-None (python#120401) Co-authored-by: Alex Waygood <alex.waygood@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this issue
Jul 17, 2024
…ns non-None (python#120401) Co-authored-by: Alex Waygood <alex.waygood@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature or enhancement
Right now there are two potential things we can improve in this warning message:
cpython/Lib/unittest/case.py
Lines 605 to 609 in 19435d2
async def test_some
is defined in a regularTestCase
class, I think that we can improve this specific case and suggest to useIsolatedAsyncioTestCase
insteadI have a patch ready.
Linked PRs
The text was updated successfully, but these errors were encountered: