-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some classes which inherit socketserver.TCPServer
should override allow_reuse_port
#120485
Comments
If we set This is a perplexing behavior to people who didn't know about it, for example, when a user started a HTTP service process when develop a new website, and modified the source code, and forgot there was already a process there, then started a new one. As a result, he will see his change works randomly. So I think it's not a good idea to set the |
…ng `socketserver.TCPServer` (GH-120488) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Can this be closed? |
…classing `socketserver.TCPServer` (pythonGH-120488) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
…classing `socketserver.TCPServer` (pythonGH-120488) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
…classing `socketserver.TCPServer` (pythonGH-120488) Co-authored-by: Vinay Sajip <vinay_sajip@yahoo.co.uk>
Bug report
Bug description:
In #30072 there was a change to
socketserver.TCPServer
which added a new variableallow_reuse_port
to support the usage ofSO_REUSEPORT
along withSO_REUSEADDR
. The problem is that the classes which inherit fromsocketserver.TCPServer
and overrideallow_reuse_address
weren't updated to include the override of the new variableallow_reuse_port
.CPython versions tested on:
3.11
Operating systems tested on:
Linux
Linked PRs
allow_reuse_port
on classes inheritingsocketserver.TCPServer
#120488The text was updated successfully, but these errors were encountered: