Skip to content

mimalloc build fails on GNU/Hurd due to undeclared 'open' #121731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sthibaul opened this issue Jul 13, 2024 · 1 comment
Closed

mimalloc build fails on GNU/Hurd due to undeclared 'open' #121731

sthibaul opened this issue Jul 13, 2024 · 1 comment
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@sthibaul
Copy link
Contributor

sthibaul commented Jul 13, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Bug description:

The compilation of mimalloc on GNU/Hurd currently fails with the following error:

In file included from ../Objects/mimalloc/prim/prim.c:22,
                 from ../Objects/mimalloc/static.c:37:
../Objects/mimalloc/prim/unix/prim.c: In function 'mi_prim_open':
../Objects/mimalloc/prim/unix/prim.c:82:10: error: implicit declaration of function 'open'; did you mean 'popen'? [-Werror=implicit-function-declaration]
   82 |   return open(fpath,open_flags);
      |          ^~~~
      |          popen

This is already fixed upstream by microsoft/mimalloc@98abfe0 . will submit a PR containing a backport

CPython versions tested on:

CPython 3.13.0 b3

CPython versions tested on:

3.13

Operating systems tested on:

Other

Linked PRs
@sthibaul sthibaul added the type-bug An unexpected behavior, bug, or error label Jul 13, 2024
sthibaul added a commit to sthibaul/cpython that referenced this issue Jul 13, 2024
@sthibaul
pythongh-121731: Fix mimalloc compile error on GNU/Hurd
f6afd1f
@bedevere-app bedevere-app bot mentioned this issue Jul 13, 2024
Merged
sthibaul added a commit to sthibaul/cpython that referenced this issue Jul 13, 2024
@sthibaul
pythongh-121731: Fix mimalloc compile error on GNU/Hurd
360de09
@Eclips4 Eclips4 added the build The build process and cross-build label Jul 14, 2024
@Eclips4
Copy link
Member

Eclips4 commented Jul 14, 2024

Related: #113141

@Eclips4 Eclips4 added 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Jul 14, 2024
colesbury pushed a commit that referenced this issue Jul 14, 2024
@sthibaul
gh-121731: Fix mimalloc compile error on GNU/Hurd (#121732)
d005f2c
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jul 14, 2024
@sthibaul @miss-islington
pythongh-121731: Fix mimalloc compile error on GNU/Hurd (pythonGH-121732
1f6ef53 
)

(cherry picked from commit d005f2c)

Co-authored-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
@bedevere-app bedevere-app bot mentioned this issue Jul 14, 2024
Merged
colesbury pushed a commit that referenced this issue Jul 14, 2024
@miss-islington @sthibaul
[3.13] gh-121731: Fix mimalloc compile error on GNU/Hurd (GH-121732) (#…
767f714 
…121773)

(cherry picked from commit d005f2c)

Co-authored-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@sthibaul @estyxx
pythongh-121731: Fix mimalloc compile error on GNU/Hurd (python#121732)
df2399c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes 3.14 new features, bugs and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colesbury @sthibaul @Eclips4