-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_pyrepl: test_inspect_keeps_globals_from_inspected_* are very flaky #121973
Labels
tests
Tests in the Lib/test dir
topic-repl
Related to the interactive shell
type-bug
An unexpected behavior, bug, or error
Comments
AlexWaygood
added
tests
Tests in the Lib/test dir
topic-repl
Related to the interactive shell
labels
Jul 18, 2024
colesbury
added a commit
to colesbury/cpython
that referenced
this issue
Jul 22, 2024
This fixes the flakiness in: * test_inspect_keeps_globals_from_inspected_file * test_inspect_keeps_globals_from_inspected_module The output already includes newlines. Adding newlines for every entry in the output list introduces non-determinism because it added '\n' in places where stdout is flushed or some buffer becomes full. The regex also needed to be updated because pyrepl includes control characters -- the visible output on each line doesn't immediately follow a newline character.
ambv
added a commit
that referenced
this issue
Jul 23, 2024
This fixes the flakiness in: * test_inspect_keeps_globals_from_inspected_file * test_inspect_keeps_globals_from_inspected_module The output already includes newlines. Adding newlines for every entry in the output list introduces non-determinism because it added '\n' in places where stdout is flushed or some buffer becomes full. The regex also needed to be updated because pyrepl includes control characters -- the visible output on each line doesn't immediately follow a newline character. Co-authored-by: Łukasz Langa <lukasz@langa.pl>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Jul 23, 2024
This fixes the flakiness in: * test_inspect_keeps_globals_from_inspected_file * test_inspect_keeps_globals_from_inspected_module The output already includes newlines. Adding newlines for every entry in the output list introduces non-determinism because it added '\n' in places where stdout is flushed or some buffer becomes full. The regex also needed to be updated because pyrepl includes control characters -- the visible output on each line doesn't immediately follow a newline character. (cherry picked from commit 2c1b1e7) Co-authored-by: Sam Gross <colesbury@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv
added a commit
that referenced
this issue
Jul 23, 2024
This fixes the flakiness in: * test_inspect_keeps_globals_from_inspected_file * test_inspect_keeps_globals_from_inspected_module The output already includes newlines. Adding newlines for every entry in the output list introduces non-determinism because it added '\n' in places where stdout is flushed or some buffer becomes full. The regex also needed to be updated because pyrepl includes control characters -- the visible output on each line doesn't immediately follow a newline character. (cherry picked from commit 2c1b1e7) Co-authored-by: Sam Gross <colesbury@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>
nohlson
pushed a commit
to nohlson/cpython
that referenced
this issue
Jul 24, 2024
This fixes the flakiness in: * test_inspect_keeps_globals_from_inspected_file * test_inspect_keeps_globals_from_inspected_module The output already includes newlines. Adding newlines for every entry in the output list introduces non-determinism because it added '\n' in places where stdout is flushed or some buffer becomes full. The regex also needed to be updated because pyrepl includes control characters -- the visible output on each line doesn't immediately follow a newline character. Co-authored-by: Łukasz Langa <lukasz@langa.pl>
nohlson
pushed a commit
to nohlson/cpython
that referenced
this issue
Jul 24, 2024
This fixes the flakiness in: * test_inspect_keeps_globals_from_inspected_file * test_inspect_keeps_globals_from_inspected_module The output already includes newlines. Adding newlines for every entry in the output list introduces non-determinism because it added '\n' in places where stdout is flushed or some buffer becomes full. The regex also needed to be updated because pyrepl includes control characters -- the visible output on each line doesn't immediately follow a newline character. Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
tests
Tests in the Lib/test dir
topic-repl
Related to the interactive shell
type-bug
An unexpected behavior, bug, or error
Bug report
Bug description:
When running the test suite on Gentoo Linux amd64 (with all CPUs busy), these tests are failing frequently:
This is with 3.13.0b4.
CPython versions tested on:
3.13
Operating systems tested on:
Linux
Linked PRs
The text was updated successfully, but these errors were encountered: