Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyType_GetBaseByToken function with Py_tp_token slot #124153

Closed
6 tasks done
neonene opened this issue Sep 17, 2024 · 2 comments
Closed
6 tasks done

Add PyType_GetBaseByToken function with Py_tp_token slot #124153

neonene opened this issue Sep 17, 2024 · 2 comments
Labels
type-feature A feature request or enhancement

Comments

@neonene
Copy link
Contributor

neonene commented Sep 17, 2024

This issue implements a proposal related to PEP-489 and PEP-630.

Decision:

TODO:

  • Implement the feature
  • Use it in _PyStgInfo_FromType_NoState() in _ctypes.c
  • Ensure no performance regression in PyType_GetModuleByDef() and other functions affected by this feature on Windows PGO builds

TODO (optional):

  • Replace PyType_GetModuleByDef() in defdict_or() (_collectionsmodule.c)
  • Replace _PyType_GetModuleByDef2() in _decimal.c
  • Remove _PyType_GetModuleByDef2()

Has this already been discussed elsewhere?

I have already discussed this feature proposal on Discourse

Links to previous discussion of this feature:

Linked PRs

@encukou
Copy link
Member

encukou commented Sep 18, 2024

The first PR is merged. Keeping this open for the other TODO items.

@neonene
Copy link
Contributor Author

neonene commented Oct 10, 2024

Completed. Thank you for allowing me to follow up.

@neonene neonene closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants