Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

urllib.request.pathname2url() raises on NTFS alternate data stream #126601

Closed
barneygale opened this issue Nov 8, 2024 · 2 comments
Closed

urllib.request.pathname2url() raises on NTFS alternate data stream #126601

barneygale opened this issue Nov 8, 2024 · 2 comments
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes type-bug An unexpected behavior, bug, or error

Comments

@barneygale
Copy link
Contributor

barneygale commented Nov 8, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

On Windows, urllib.request.pathname2url() raises OSError when given a path with a colon in any position other than the second character. This excludes paths with NTFS alternate data streams, which are valid in other path-processing functions (e.g. in os.path and pathlib):

>>> from urllib.request import pathname2url
>>> pathname2url(r'C:\foo:bar')
OSError: Bad path: C:/foo:bar  # expected: ///C:/foo%3Abar
>>> pathname2url(r'foo:bar')
OSError: Bad path: foo:bar  # expected: foo%3Abar

CPython versions tested on:

CPython main branch

Operating systems tested on:

Windows

Linked PRs
@barneygale barneygale added type-bug An unexpected behavior, bug, or error 3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Nov 8, 2024
@barneygale
Copy link
Contributor Author

Suggest we wait for #120423 to be fixed before tackling this one, as the required changes touch the same lines of code.

barneygale added a commit to barneygale/cpython that referenced this issue Nov 12, 2024
@barneygale
pythonGH-126601: pathname2url(): handle NTFS alternate data streams
0ed23a5 
Adjust `pathname2url()` to encode embedded colon characters in Windows
paths, rather than bailing out with an `OSError`.
@bedevere-app bedevere-app bot mentioned this issue Nov 12, 2024
Merged
barneygale added a commit to barneygale/cpython that referenced this issue Nov 19, 2024
@barneygale
Merge branch 'main' into pythongh-126601
4c6168a
barneygale added a commit that referenced this issue Nov 22, 2024
@barneygale @zooba
GH-126601: pathname2url(): handle NTFS alternate data streams (#126760
fd133d4 
)

Adjust `pathname2url()` to encode embedded colon characters in Windows
paths, rather than bailing out with an `OSError`.

Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@barneygale
Copy link
Contributor Author

Fixed in 3.14, but not backported as it's a pretty rare bug.

@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@barneygale