Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emscripten support: Remove --with-emscripten-target #126691

Closed
hoodmane opened this issue Nov 11, 2024 · 1 comment
Closed

Emscripten support: Remove --with-emscripten-target #126691

hoodmane opened this issue Nov 11, 2024 · 1 comment
Labels
build The build process and cross-build OS-emscripten

Comments

@hoodmane
Copy link
Contributor

hoodmane commented Nov 11, 2024 •
edited by bedevere-app bot
Loading

It's possible to support both node and the browser with a single configuration, for instance Pyodide does this. I think this is preferable since it's fewer options to have test coverage for or to not cover and be in doubt about whether they work. Requires refactoring the way the Python.html example and node runner work.

cc @freakboy3742

Linked PRs
@hoodmane hoodmane added OS-emscripten build The build process and cross-build labels Nov 11, 2024
@freakboy3742
Copy link
Contributor

If this is possible, I agree it would be preferable.

hoodmane added a commit to hoodmane/cpython that referenced this issue Nov 13, 2024
@hoodmane
pythongh-126691: Remove --with-emscripten-target
434f67f 
This unifies the code for nodejs and the code for the browser. After this
commit, the browser example doesn't work. However, I have a fix for it prepared
as a followup.
@bedevere-app bedevere-app bot mentioned this issue Nov 13, 2024
Merged
freakboy3742 pushed a commit that referenced this issue Nov 16, 2024
@hoodmane
gh-126691: Remove --with-emscripten-target (#126787)
544b001 
This unifies the code for nodejs and the code for the browser. After this
commit, the browser example doesn't work; this will be fixed in a
subsequent update.
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
picnixz pushed a commit to picnixz/cpython that referenced this issue Dec 8, 2024
@hoodmane @picnixz
pythongh-126691: Remove --with-emscripten-target (python#126787)
0974f20 
This unifies the code for nodejs and the code for the browser. After this
commit, the browser example doesn't work; this will be fixed in a
subsequent update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build OS-emscripten
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@freakboy3742 @hoodmane