Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warmup counters should be reset when JIT compiling code #126892

Closed
brandtbucher opened this issue Nov 16, 2024 · 0 comments
Closed

Warmup counters should be reset when JIT compiling code #126892

brandtbucher opened this issue Nov 16, 2024 · 0 comments
Assignees
@brandtbucher
Labels
3.14 new features, bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage topic-JIT

Comments

@brandtbucher
Copy link
Member

brandtbucher commented Nov 16, 2024 •
edited by bedevere-app bot
Loading

When we tier up into the JIT, we don't reset the warmup counter to a non-zero value. This means that after JIT code is invalidated (either because of watchers or because it's cold), we'll re-JIT that code the very next time it's hit. That's not ideal.

Linked PRs
@brandtbucher brandtbucher added performance Performance or resource usage interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.14 new features, bugs and security fixes topic-JIT labels Nov 16, 2024
@brandtbucher brandtbucher self-assigned this Nov 16, 2024
@bedevere-app bedevere-app bot mentioned this issue Nov 16, 2024
Merged
brandtbucher added a commit that referenced this issue Nov 20, 2024
@brandtbucher
GH-126892: Reset warmup counters when JIT compiling code (GH-126893)
48c50ff
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandtbucher brandtbucher

Labels
3.14 new features, bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage topic-JIT
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brandtbucher